From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression
Date: Thu, 29 Aug 2013 14:51:00 -0000 [thread overview]
Message-ID: <521F5FD1.8020107@redhat.com> (raw)
In-Reply-To: <87a9k0sgpf.fsf@fleche.redhat.com>
On 08/29/2013 03:40 PM, Tom Tromey wrote:
>>> * There is no real need for SOCK_CLOEXEC, GDB benefits from it for Python
>>> threads (possibly calling their own fork+exec) but those do not happen for
>>> gdbserver.
>
> Pedro> I suspect we'll have to revisit this at some point (years from now),
> Pedro> but yeah, agreed.
>
> gdbserver on trunk can just use the filestuff.c code.
Yeah, it already does:
https://sourceware.org/ml/gdb-patches/2013-08/msg00765.html
but it doesn't call socket_mark_cloexec or similars, so we'll
probably still have to revisit this at some point (years
from now). :-)
--
Pedro Alves
next prev parent reply other threads:[~2013-08-29 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 11:11 Jan Kratochvil
2013-08-29 12:15 ` Pedro Alves
2013-08-29 13:04 ` Jan Kratochvil
2013-08-29 14:17 ` Pedro Alves
2013-08-29 14:27 ` [commit 7.6.1 only] " Jan Kratochvil
2013-08-29 14:39 ` Pedro Alves
2013-08-29 14:40 ` Tom Tromey
2013-08-29 14:51 ` Pedro Alves [this message]
2013-08-29 15:00 ` Tom Tromey
2013-08-29 17:22 ` Tom Tromey
2013-08-29 17:47 ` Pedro Alves
2013-08-29 18:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F5FD1.8020107@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox