From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21635 invoked by alias); 29 Aug 2013 14:51:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21626 invoked by uid 89); 29 Aug 2013 14:51:02 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2013 14:51:02 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TEoxlg022440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 10:50:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7TEowAA019345; Thu, 29 Aug 2013 10:50:58 -0400 Message-ID: <521F5FD1.8020107@redhat.com> Date: Thu, 29 Aug 2013 14:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression References: <20130829111053.GA25662@host2.jankratochvil.net> <521F3B71.1010007@redhat.com> <20130829130359.GA31063@host2.jankratochvil.net> <521F5804.1080604@redhat.com> <87a9k0sgpf.fsf@fleche.redhat.com> In-Reply-To: <87a9k0sgpf.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00875.txt.bz2 On 08/29/2013 03:40 PM, Tom Tromey wrote: >>> * There is no real need for SOCK_CLOEXEC, GDB benefits from it for Python >>> threads (possibly calling their own fork+exec) but those do not happen for >>> gdbserver. > > Pedro> I suspect we'll have to revisit this at some point (years from now), > Pedro> but yeah, agreed. > > gdbserver on trunk can just use the filestuff.c code. Yeah, it already does: https://sourceware.org/ml/gdb-patches/2013-08/msg00765.html but it doesn't call socket_mark_cloexec or similars, so we'll probably still have to revisit this at some point (years from now). :-) -- Pedro Alves