From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression
Date: Thu, 29 Aug 2013 12:15:00 -0000 [thread overview]
Message-ID: <521F3B71.1010007@redhat.com> (raw)
In-Reply-To: <20130829111053.GA25662@host2.jankratochvil.net>
On 08/29/2013 12:10 PM, Jan Kratochvil wrote:
> Hi,
>
> in
> [commit without 7.6.1] [gdbserver patch] [7.6.1] Fix fd leak regression
> https://sourceware.org/ml/gdb-patches/2013-08/msg00845.html
> I wrote:
> # Although without 7.6.1 - 7.6 does not yet have gdb/common/filestuff.[ch] and
> # from various available solutions I think it is just OK to wait for 7.7.
>
> As I found I would like even 7.6.x fixed I wrote this alternative patch.
>
(We could also just mark the sockets as SOCK_CLOEXEC, I think?
Though that's "only" since Linux 2.6.27, so I've no objection with
going this route.)
I think we need to close remote_desc too. With plain "target remote",
the inferior is spawned before gdb connects, but with extended-remote+"run",
that's not the case.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-29 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 11:11 Jan Kratochvil
2013-08-29 12:15 ` Pedro Alves [this message]
2013-08-29 13:04 ` Jan Kratochvil
2013-08-29 14:17 ` Pedro Alves
2013-08-29 14:27 ` [commit 7.6.1 only] " Jan Kratochvil
2013-08-29 14:39 ` Pedro Alves
2013-08-29 14:40 ` Tom Tromey
2013-08-29 14:51 ` Pedro Alves
2013-08-29 15:00 ` Tom Tromey
2013-08-29 17:22 ` Tom Tromey
2013-08-29 17:47 ` Pedro Alves
2013-08-29 18:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F3B71.1010007@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox