From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: [commit 7.6.1 only] [patch gdbserver 7.6.1 only] Fix fd leak regression
Date: Thu, 29 Aug 2013 14:27:00 -0000 [thread overview]
Message-ID: <20130829142719.GA4036@host2.jankratochvil.net> (raw)
In-Reply-To: <521F5804.1080604@redhat.com>
On Thu, 29 Aug 2013 16:17:40 +0200, Pedro Alves wrote:
> Thanks, this looks good to me.
Checked in:
https://sourceware.org/ml/gdb-cvs/2013-08/msg00161.html
> > +set test "system fd behavior is known"
> > +set status [remote_exec target "[standard_output_file $testfile]"]
> > +if { [lindex $status 0] == 0 } {
> > + pass $test
> > +} else {
> > + fail $test
> > +}
> > +remote_exec target "ls -l /proc/self/fd/"
>
> Before gdbserver's fix, do we get one extra fd from the dejagnu
> leak, and another extra from gdbserver's leak? What if we made
> $testfile count open fds, and then compare that between running
> under gdb/gdbserver and just under remote_exec ?
BTW not sure if it is clear but this gdb/testsuite/ part was sent
accidentally, there is even written no real test and I have not checked in
anything as I got stuck on the DejaGNU bug.
I have sent a bugreport to <bug-dejagnu@gnu.org> and it got processed today
although the mail has not yet appeared in the archive:
http://lists.gnu.org/archive/html/bug-dejagnu/
I hope DejaGNU gets fixed soon so the testcase can be later written as
UNSUPPORTED (UNTESTED?) with buggy DejaGNU.
Thanks,
Jan
next prev parent reply other threads:[~2013-08-29 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 11:11 Jan Kratochvil
2013-08-29 12:15 ` Pedro Alves
2013-08-29 13:04 ` Jan Kratochvil
2013-08-29 14:17 ` Pedro Alves
2013-08-29 14:27 ` Jan Kratochvil [this message]
2013-08-29 14:39 ` [commit 7.6.1 only] " Pedro Alves
2013-08-29 14:40 ` Tom Tromey
2013-08-29 14:51 ` Pedro Alves
2013-08-29 15:00 ` Tom Tromey
2013-08-29 17:22 ` Tom Tromey
2013-08-29 17:47 ` Pedro Alves
2013-08-29 18:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829142719.GA4036@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox