From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression
Date: Thu, 29 Aug 2013 18:27:00 -0000 [thread overview]
Message-ID: <87bo4gqrmq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <521F8912.2020102@redhat.com> (Pedro Alves's message of "Thu, 29 Aug 2013 18:46:58 +0100")
Tom> second, the in process agent can't use gdb_socket_cloexec
Pedro> But, why ?
filestuff.o isn't available there. I guess it could be?
I will give it a whirl.
>> - open ("/dev/null", O_RDONLY);
>> + gdb_open_cloexec ("/dev/null", O_RDONLY, 0);
Pedro> This is the child opening its stdin. Doesn't look
Pedro> correct to close it on the subsequent exec.
Hahaha, barf.
Tom
prev parent reply other threads:[~2013-08-29 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 11:11 Jan Kratochvil
2013-08-29 12:15 ` Pedro Alves
2013-08-29 13:04 ` Jan Kratochvil
2013-08-29 14:17 ` Pedro Alves
2013-08-29 14:27 ` [commit 7.6.1 only] " Jan Kratochvil
2013-08-29 14:39 ` Pedro Alves
2013-08-29 14:40 ` Tom Tromey
2013-08-29 14:51 ` Pedro Alves
2013-08-29 15:00 ` Tom Tromey
2013-08-29 17:22 ` Tom Tromey
2013-08-29 17:47 ` Pedro Alves
2013-08-29 18:27 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo4gqrmq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox