From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29895 invoked by alias); 29 Aug 2013 12:15:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29873 invoked by uid 89); 29 Aug 2013 12:15:50 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2013 12:15:50 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TCFlkd016928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 08:15:48 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7TCFjMA026340; Thu, 29 Aug 2013 08:15:47 -0400 Message-ID: <521F3B71.1010007@redhat.com> Date: Thu, 29 Aug 2013 12:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression References: <20130829111053.GA25662@host2.jankratochvil.net> In-Reply-To: <20130829111053.GA25662@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00865.txt.bz2 On 08/29/2013 12:10 PM, Jan Kratochvil wrote: > Hi, > > in > [commit without 7.6.1] [gdbserver patch] [7.6.1] Fix fd leak regression > https://sourceware.org/ml/gdb-patches/2013-08/msg00845.html > I wrote: > # Although without 7.6.1 - 7.6 does not yet have gdb/common/filestuff.[ch] and > # from various available solutions I think it is just OK to wait for 7.7. > > As I found I would like even 7.6.x fixed I wrote this alternative patch. > (We could also just mark the sockets as SOCK_CLOEXEC, I think? Though that's "only" since Linux 2.6.27, so I've no objection with going this route.) I think we need to close remote_desc too. With plain "target remote", the inferior is spawned before gdb connects, but with extended-remote+"run", that's not the case. -- Pedro Alves