Re: [PATCH] PR gdb/15871: Unavailable entry value is not shown correctly

[Yao Qi <yao@codesourcery.com>]

On 08/21/2013 11:32 PM, Pedro Alves wrote:
> I looked
> around a bit over memory_error calls, and the need to handle random
> errno values, other than the EIOs gdb itself hardcodes, probably comes
> (only) from deprecated_xfer_memory, which uses errno for error

Is it in function default_xfer_partial?

> indication, but I didn't look exhaustively.  We should really get rid
> of that...)
>

What do you mean by "that"? using errno for error indication?

> +/* Report a target xfer memory error by throwing a suitable
> +   exception.  */
> +
> +static void
> +target_xfer_memory_error (enum target_xfer_error err, CORE_ADDR memaddr)
> +{
> +  switch (err)
> +    {
> +    case TARGET_XFER_E_IO:
> +      /* Actually, address between memaddr and memaddr + len was out of
> +	 bounds.  */

This line of comment doesn't make much sense in the context of this
function.

This patch looks good to me.  Please commit it without the change to
gdb.trace/entry-values.exp, and I'll update my patch to remove kfail.

A suggestion here, IWBN to print the string of 'enum target_xfer_error'
in the debugging message at the end of target_xfer_partial.  We are
print numbers currently.

-- 
Yao (齐尧)