From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29194 invoked by alias); 22 Aug 2013 01:25:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29156 invoked by uid 89); 22 Aug 2013 01:25:10 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.2 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 22 Aug 2013 01:25:09 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VCJe6-0004Nw-HT from Yao_Qi@mentor.com ; Wed, 21 Aug 2013 18:25:06 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 21 Aug 2013 18:25:06 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Wed, 21 Aug 2013 18:25:05 -0700 Message-ID: <52156841.8030105@codesourcery.com> Date: Thu, 22 Aug 2013 01:25:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Mark Kettenis , , Subject: Re: [PATCH] PR gdb/15871: Unavailable entry value is not shown correctly References: <1376379586-24150-1-git-send-email-yao@codesourcery.com> <1376379586-24150-3-git-send-email-yao@codesourcery.com> <87siy4gsn4.fsf@fleche.redhat.com> <521458A8.7060304@codesourcery.com> <5214D03C.9040703@redhat.com> <201308211447.r7LEld3t025510@glazunov.sibelius.xs4all.nl> <5214DD85.5060605@redhat.com> In-Reply-To: <5214DD85.5060605@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00617.txt.bz2 On 08/21/2013 11:32 PM, Pedro Alves wrote: > I looked > around a bit over memory_error calls, and the need to handle random > errno values, other than the EIOs gdb itself hardcodes, probably comes > (only) from deprecated_xfer_memory, which uses errno for error Is it in function default_xfer_partial? > indication, but I didn't look exhaustively. We should really get rid > of that...) > What do you mean by "that"? using errno for error indication? > +/* Report a target xfer memory error by throwing a suitable > + exception. */ > + > +static void > +target_xfer_memory_error (enum target_xfer_error err, CORE_ADDR memaddr) > +{ > + switch (err) > + { > + case TARGET_XFER_E_IO: > + /* Actually, address between memaddr and memaddr + len was out of > + bounds. */ This line of comment doesn't make much sense in the context of this function. This patch looks good to me. Please commit it without the change to gdb.trace/entry-values.exp, and I'll update my patch to remove kfail. A suggestion here, IWBN to print the string of 'enum target_xfer_error' in the debugging message at the end of target_xfer_partial. We are print numbers currently. -- Yao (齐尧)