From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC 2/2] Test entry values in trace frame
Date: Tue, 20 Aug 2013 17:48:00 -0000 [thread overview]
Message-ID: <87siy4gsn4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1376379586-24150-3-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Tue, 13 Aug 2013 15:39:46 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> I don't emit a fail for it because I am not very sure it is expected
Yao> to be "unavailable". I am fine to kfail it.
Yao> I looked into a little, and looks reading entry value doesn't use
Yao> value availability-aware API. It is not an easy fix to me.
I think on the whole I'd rather we not check in a test that fails.
I know we already have tests like that, but what I've noticed is that
these tests only ever seem to be fixed as a side effect of fixing
something else. Otherwise the failures are just universally ignored.
I suppose the best thing to do is to file a bug about this problem.
Then you can attach this patch to the bug.
What do you think?
Tom
next prev parent reply other threads:[~2013-08-20 17:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:41 [PATCH 0/2] Test case on entry values Yao Qi
2013-08-13 7:41 ` [RFC 2/2] Test entry values in trace frame Yao Qi
2013-08-20 17:48 ` Tom Tromey [this message]
2013-08-21 6:06 ` Yao Qi
2013-08-21 14:35 ` [PATCH] PR gdb/15871: Unavailable entry value is not shown correctly Pedro Alves
2013-08-21 14:47 ` Mark Kettenis
2013-08-21 15:32 ` Pedro Alves
2013-08-21 15:43 ` Mark Kettenis
2013-08-22 1:25 ` Yao Qi
2013-08-22 10:04 ` [COMMIT] " Pedro Alves
2013-08-23 1:08 ` Yao Qi
2013-08-23 16:50 ` Pedro Alves
2013-08-23 0:32 ` [RFC 2/2] Test entry values in trace frame Yao Qi
2013-08-23 17:04 ` Pedro Alves
2013-08-23 19:16 ` Tom Tromey
2013-08-24 1:56 ` Yao Qi
2013-08-13 7:41 ` [PATCH 1/2] Test case for entry values Yao Qi
2013-08-20 17:39 ` Tom Tromey
2013-08-21 5:55 ` Yao Qi
2013-08-21 15:02 ` Tom Tromey
2013-08-22 0:12 ` Yao Qi
2013-08-22 14:05 ` Tom Tromey
2013-08-23 0:27 ` Yao Qi
2013-08-23 19:23 ` Tom Tromey
2013-08-24 1:56 ` Yao Qi
2013-08-30 14:52 ` Vidya Praveen
2013-08-30 15:29 ` Vidya Praveen
2013-08-31 0:22 ` Yao Qi
2013-09-10 15:30 ` Vidya Praveen
2013-09-10 23:44 ` Yao Qi
2013-09-11 13:27 ` Vidya Praveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siy4gsn4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox