From: Yao Qi <yao@codesourcery.com>
To: Vidya Praveen <vidyapraveen@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Test case for entry values.
Date: Tue, 10 Sep 2013 23:44:00 -0000 [thread overview]
Message-ID: <522FAE9C.2000206@codesourcery.com> (raw)
In-Reply-To: <20130910153019.GA2535@e103625-lin.cambridge.arm.com>
On 09/10/2013 11:30 PM, Vidya Praveen wrote:
> OK. But isn't it better to have the condition (!gdb_target_supports_trace)
> that checks if the target supports tracing, in the beginning of the test
> rather than much later?
This part of test is about testing entry values, and the bottom part
(added by patch 2/2) is about testing unavailable entry values when
examining trace frames. This part is not related to tracing, so we
can't use gdb_target_supports_trace to check.
See my description in "PATCH 0/2"
> Patch 1/2 is to generate dwarf using Dwarf Assembler to test "entry values"
> are shown correctly. At this point, gdb.trace/entry-values.exp is still
> a dwarf test, nothing to do with trace. Patch 2/2 is to use tracepoint,
> to collect data, to test what happen when argument is available and entry
> value is not.
https://sourceware.org/ml/gdb-patches/2013-08/msg00327.html
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-09-10 23:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:41 [PATCH 0/2] Test case on " Yao Qi
2013-08-13 7:41 ` [RFC 2/2] Test entry values in trace frame Yao Qi
2013-08-20 17:48 ` Tom Tromey
2013-08-21 6:06 ` Yao Qi
2013-08-21 14:35 ` [PATCH] PR gdb/15871: Unavailable entry value is not shown correctly Pedro Alves
2013-08-21 14:47 ` Mark Kettenis
2013-08-21 15:32 ` Pedro Alves
2013-08-21 15:43 ` Mark Kettenis
2013-08-22 1:25 ` Yao Qi
2013-08-22 10:04 ` [COMMIT] " Pedro Alves
2013-08-23 1:08 ` Yao Qi
2013-08-23 16:50 ` Pedro Alves
2013-08-23 0:32 ` [RFC 2/2] Test entry values in trace frame Yao Qi
2013-08-23 17:04 ` Pedro Alves
2013-08-23 19:16 ` Tom Tromey
2013-08-24 1:56 ` Yao Qi
2013-08-13 7:41 ` [PATCH 1/2] Test case for entry values Yao Qi
2013-08-20 17:39 ` Tom Tromey
2013-08-21 5:55 ` Yao Qi
2013-08-21 15:02 ` Tom Tromey
2013-08-22 0:12 ` Yao Qi
2013-08-22 14:05 ` Tom Tromey
2013-08-23 0:27 ` Yao Qi
2013-08-23 19:23 ` Tom Tromey
2013-08-24 1:56 ` Yao Qi
2013-08-30 14:52 ` Vidya Praveen
2013-08-30 15:29 ` Vidya Praveen
2013-08-31 0:22 ` Yao Qi
2013-09-10 15:30 ` Vidya Praveen
2013-09-10 23:44 ` Yao Qi [this message]
2013-09-11 13:27 ` Vidya Praveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522FAE9C.2000206@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=vidyapraveen@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox