From: Mircea Gherzan <mircea.gherzan@intel.com>
To: Pedro Alves <palves@redhat.com>
Cc: tromey@redhat.com, jan.kratochvil@redhat.com,
gdb-patches@sourceware.org
Subject: Re: [PATCH 7/7] gdbserver: add fallback implementation for memmem
Date: Fri, 28 Jun 2013 15:18:00 -0000 [thread overview]
Message-ID: <51CDA85B.40503@intel.com> (raw)
In-Reply-To: <51CC9097.6000505@redhat.com>
On 27.06.2013 21:20, Pedro Alves wrote:
> I'll review the rest of the series later, but ...
>
> On 06/27/2013 09:43 AM, Mircea Gherzan wrote:
>> The memmem() function is a GNU extension.
>>
>> 2013-06-26 Mircea Gherzan <mircea.gherzan@intel.com>
>>
>> gdbserver/
>>
>> * configure.ac (AC_CHECK_FUNCS): Add memmem.
>> * configure: Rebuild.
>> * config.in: Rebuild.
>> * server.c (memmem): New function, included only if it's not
>> already provided by the system.
>
> We already pull in a fallback memmem from gnulib. You need
> to figure out why that isn't working for you.
Thanks for pointing this out. Will remove this patch from the series.
Mircea
--
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2013-06-28 15:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 8:44 [PATCH 0/7] increase the portability of the gdbserver code Mircea Gherzan
2013-06-27 8:44 ` [PATCH 6/7] common: add an alternative implementation for xstrvprintf Mircea Gherzan
2013-07-29 19:16 ` Tom Tromey
2013-06-27 8:44 ` [PATCH 4/7] gdbserver: conditionally include sys/param.h and sys/time.h Mircea Gherzan
2013-06-28 16:34 ` Tom Tromey
2013-07-02 14:46 ` Mircea Gherzan
2013-06-27 8:44 ` [PATCH 2/7] gdbserver, common: convert some variadic macros to C99 Mircea Gherzan
2013-06-28 16:02 ` Tom Tromey
2013-06-27 8:44 ` [PATCH 1/7] gdbserver, common: conditionally include the unistd.h Mircea Gherzan
2013-06-27 13:29 ` Pedro Alves
2013-06-27 19:19 ` Pedro Alves
2013-06-28 15:16 ` Mircea Gherzan
2013-06-28 18:26 ` Pedro Alves
2013-07-01 11:32 ` Pedro Alves
2013-06-27 8:44 ` [PATCH 3/7] gdbserver: avoid empty structs when not using GCC Mircea Gherzan
2013-06-28 16:04 ` Tom Tromey
2013-06-27 8:45 ` [PATCH 7/7] gdbserver: add fallback implementation for memmem Mircea Gherzan
2013-06-27 19:27 ` Pedro Alves
2013-06-28 15:18 ` Mircea Gherzan [this message]
2013-06-27 11:32 ` [PATCH 5/7] gdbserver, win32: fix some function typedefs Mircea Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CDA85B.40503@intel.com \
--to=mircea.gherzan@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox