Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Mircea Gherzan <mircea.gherzan@intel.com>
Cc: tromey@redhat.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h
Date: Thu, 27 Jun 2013 19:19:00 -0000	[thread overview]
Message-ID: <51CC8B72.3070208@redhat.com> (raw)
In-Reply-To: <51CC22C2.2020906@redhat.com>

On 06/27/2013 12:32 PM, Pedro Alves wrote:
> On 06/27/2013 09:43 AM, Mircea Gherzan wrote:
>> 2013-06-25  Mircea Gherzan  <mircea.gherzan@intel.com>
>>
>> 	* common/agent.c: Conditionally include unistd.h.
>>
>> gdbserver/
>> 	* hostio.c: Conditionally include unistd.h and define PATH_MAX
>> 	if unistd.h is not available.
>> 	* tracepoint.h: Conditionally include unistd.h.
> 
> Hmm, I've discussed this PATH_MAX issue before.
> I think we should pull in the unistd and pathmax modules from
> gnulib.  In hostio.c, we should cap the max path len to the max
> of PATH_MAX (if defined, it won't on the Hurd), and the packet buffer
> size.  Let me post a series for that.

Posted at:

 http://sourceware.org/ml/gdb-patches/2013-06/msg00838.html

Could you give it a try?

-- 
Pedro Alves


  reply	other threads:[~2013-06-27 18:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  8:44 [PATCH 0/7] increase the portability of the gdbserver code Mircea Gherzan
2013-06-27  8:44 ` [PATCH 4/7] gdbserver: conditionally include sys/param.h and sys/time.h Mircea Gherzan
2013-06-28 16:34   ` Tom Tromey
2013-07-02 14:46     ` Mircea Gherzan
2013-06-27  8:44 ` [PATCH 6/7] common: add an alternative implementation for xstrvprintf Mircea Gherzan
2013-07-29 19:16   ` Tom Tromey
2013-06-27  8:44 ` [PATCH 3/7] gdbserver: avoid empty structs when not using GCC Mircea Gherzan
2013-06-28 16:04   ` Tom Tromey
2013-06-27  8:44 ` [PATCH 2/7] gdbserver, common: convert some variadic macros to C99 Mircea Gherzan
2013-06-28 16:02   ` Tom Tromey
2013-06-27  8:44 ` [PATCH 1/7] gdbserver, common: conditionally include the unistd.h Mircea Gherzan
2013-06-27 13:29   ` Pedro Alves
2013-06-27 19:19     ` Pedro Alves [this message]
2013-06-28 15:16       ` Mircea Gherzan
2013-06-28 18:26         ` Pedro Alves
2013-07-01 11:32           ` Pedro Alves
2013-06-27  8:45 ` [PATCH 7/7] gdbserver: add fallback implementation for memmem Mircea Gherzan
2013-06-27 19:27   ` Pedro Alves
2013-06-28 15:18     ` Mircea Gherzan
2013-06-27 11:32 ` [PATCH 5/7] gdbserver, win32: fix some function typedefs Mircea Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CC8B72.3070208@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=mircea.gherzan@intel.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox