Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h

[Pedro Alves <palves@redhat.com>]

On 06/28/2013 04:11 PM, Mircea Gherzan wrote:
> On 27.06.2013 20:58, Pedro Alves wrote:
>> On 06/27/2013 12:32 PM, Pedro Alves wrote:
>>> On 06/27/2013 09:43 AM, Mircea Gherzan wrote:
>>>> 2013-06-25  Mircea Gherzan  <mircea.gherzan@intel.com>
>>>>
>>>> 	* common/agent.c: Conditionally include unistd.h.
>>>>
>>>> gdbserver/
>>>> 	* hostio.c: Conditionally include unistd.h and define PATH_MAX
>>>> 	if unistd.h is not available.
>>>> 	* tracepoint.h: Conditionally include unistd.h.
>>>
>>> Hmm, I've discussed this PATH_MAX issue before.
>>> I think we should pull in the unistd and pathmax modules from
>>> gnulib.  In hostio.c, we should cap the max path len to the max
>>> of PATH_MAX (if defined, it won't on the Hurd), and the packet buffer
>>> size.  Let me post a series for that.
>>
>> Posted at:
>>
>>   http://sourceware.org/ml/gdb-patches/2013-06/msg00838.html
>>
>> Could you give it a try?
> 
> Work fine in my case, thanks! 

Excellent!

> Please commit it so I can rebase my series on top of it.

I'll apply this Monday.  (I'm about to end my day, so I'd prefer not
rushing this in Friday evening, and leave the tree broken for the
weekend in case I don't get to park in front of the computer.)

Meanwhile, you could rebase on the branch I pushed to github, if
you're using git.

-- 
Pedro Alves