Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mircea Gherzan <mircea.gherzan@intel.com>
To: tromey@redhat.com, palves@redhat.com, jan.kratochvil@redhat.com
Cc: gdb-patches@sourceware.org, Mircea Gherzan <mircea.gherzan@intel.com>
Subject: [PATCH 7/7] gdbserver: add fallback implementation for memmem
Date: Thu, 27 Jun 2013 08:45:00 -0000	[thread overview]
Message-ID: <1372322622-3216-8-git-send-email-mircea.gherzan@intel.com> (raw)
In-Reply-To: <1372322622-3216-1-git-send-email-mircea.gherzan@intel.com>

The memmem() function is a GNU extension.

2013-06-26  Mircea Gherzan  <mircea.gherzan@intel.com>

gdbserver/

	* configure.ac (AC_CHECK_FUNCS): Add memmem.
	* configure: Rebuild.
	* config.in: Rebuild.
	* server.c (memmem): New function, included only if it's not
	already provided by the system.

Signed-off-by: Mircea Gherzan <mircea.gherzan@intel.com>
---
 gdb/gdbserver/config.in    |  3 +++
 gdb/gdbserver/configure    |  2 +-
 gdb/gdbserver/configure.ac |  2 +-
 gdb/gdbserver/server.c     | 23 +++++++++++++++++++++++
 4 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/gdb/gdbserver/config.in b/gdb/gdbserver/config.in
index 4a5a51d..5ed56c3 100644
--- a/gdb/gdbserver/config.in
+++ b/gdb/gdbserver/config.in
@@ -97,6 +97,9 @@
 /* Define to 1 if you have the <malloc.h> header file. */
 #undef HAVE_MALLOC_H
 
+/* Define to 1 if you have the `memmem' function. */
+#undef HAVE_MEMMEM
+
 /* Define to 1 if you have the <memory.h> header file. */
 #undef HAVE_MEMORY_H
 
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 5df8fe3..874a899 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -4795,7 +4795,7 @@ fi
 
 done
 
-for ac_func in pread pwrite pread64 readlink fdwalk pipe2
+for ac_func in pread pwrite pread64 readlink fdwalk pipe2 memmem
 do :
   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 8142e91..7cbc6ea 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -70,7 +70,7 @@ AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h string.h dnl
 		 sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
 		 netinet/tcp.h arpa/inet.h sys/wait.h wait.h sys/un.h dnl
 		 linux/perf_event.h sys/time.h sys/param.h)
-AC_CHECK_FUNCS(pread pwrite pread64 readlink fdwalk pipe2)
+AC_CHECK_FUNCS(pread pwrite pread64 readlink fdwalk pipe2 memmem)
 AC_REPLACE_FUNCS(vasprintf vsnprintf)
 
 # Check for UST
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index 4a1d1dc..99c2229 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -761,6 +761,29 @@ gdb_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, int len)
     }
 }
 
+#ifndef HAVE_MEMMEM
+
+/* Find the NEEDLE in the HAYSTACK and return its position.  */
+
+static void *
+memmem (const void *haystack, size_t haystack_len, const void *needle,
+	size_t needle_len)
+{
+  size_t i;
+  const gdb_byte *p;
+
+  for (i = 0; i <= haystack_len - needle_len; i++)
+    {
+      p = (gdb_byte *)haystack + i;
+      if (memcmp (p, needle, needle_len) == 0)
+	return p;
+    }
+
+  return NULL;
+}
+
+#endif
+
 /* Subroutine of handle_search_memory to simplify it.  */
 
 static int
-- 
1.7.12.4


  parent reply	other threads:[~2013-06-27  8:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  8:44 [PATCH 0/7] increase the portability of the gdbserver code Mircea Gherzan
2013-06-27  8:44 ` [PATCH 3/7] gdbserver: avoid empty structs when not using GCC Mircea Gherzan
2013-06-28 16:04   ` Tom Tromey
2013-06-27  8:44 ` [PATCH 2/7] gdbserver, common: convert some variadic macros to C99 Mircea Gherzan
2013-06-28 16:02   ` Tom Tromey
2013-06-27  8:44 ` [PATCH 1/7] gdbserver, common: conditionally include the unistd.h Mircea Gherzan
2013-06-27 13:29   ` Pedro Alves
2013-06-27 19:19     ` Pedro Alves
2013-06-28 15:16       ` Mircea Gherzan
2013-06-28 18:26         ` Pedro Alves
2013-07-01 11:32           ` Pedro Alves
2013-06-27  8:44 ` [PATCH 6/7] common: add an alternative implementation for xstrvprintf Mircea Gherzan
2013-07-29 19:16   ` Tom Tromey
2013-06-27  8:44 ` [PATCH 4/7] gdbserver: conditionally include sys/param.h and sys/time.h Mircea Gherzan
2013-06-28 16:34   ` Tom Tromey
2013-07-02 14:46     ` Mircea Gherzan
2013-06-27  8:45 ` Mircea Gherzan [this message]
2013-06-27 19:27   ` [PATCH 7/7] gdbserver: add fallback implementation for memmem Pedro Alves
2013-06-28 15:18     ` Mircea Gherzan
2013-06-27 11:32 ` [PATCH 5/7] gdbserver, win32: fix some function typedefs Mircea Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372322622-3216-8-git-send-email-mircea.gherzan@intel.com \
    --to=mircea.gherzan@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox