From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15244 invoked by alias); 27 Jun 2013 18:59:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15235 invoked by uid 89); 27 Jun 2013 18:59:03 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 27 Jun 2013 18:59:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5RIx0R1011808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Jun 2013 14:59:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5RIwwQd027898; Thu, 27 Jun 2013 14:58:59 -0400 Message-ID: <51CC8B72.3070208@redhat.com> Date: Thu, 27 Jun 2013 19:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Mircea Gherzan CC: tromey@redhat.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h References: <1372322622-3216-1-git-send-email-mircea.gherzan@intel.com> <1372322622-3216-2-git-send-email-mircea.gherzan@intel.com> <51CC22C2.2020906@redhat.com> In-Reply-To: <51CC22C2.2020906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00850.txt.bz2 On 06/27/2013 12:32 PM, Pedro Alves wrote: > On 06/27/2013 09:43 AM, Mircea Gherzan wrote: >> 2013-06-25 Mircea Gherzan >> >> * common/agent.c: Conditionally include unistd.h. >> >> gdbserver/ >> * hostio.c: Conditionally include unistd.h and define PATH_MAX >> if unistd.h is not available. >> * tracepoint.h: Conditionally include unistd.h. > > Hmm, I've discussed this PATH_MAX issue before. > I think we should pull in the unistd and pathmax modules from > gnulib. In hostio.c, we should cap the max path len to the max > of PATH_MAX (if defined, it won't on the Hurd), and the packet buffer > size. Let me post a series for that. Posted at: http://sourceware.org/ml/gdb-patches/2013-06/msg00838.html Could you give it a try? -- Pedro Alves