From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1725 invoked by alias); 28 Jun 2013 15:16:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1716 invoked by uid 89); 28 Jun 2013 15:16:48 -0000 X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 15:16:47 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 28 Jun 2013 08:15:52 -0700 X-ExtLoop1: 1 Received: from mirceagh-mobl.ger.corp.intel.com (HELO [172.28.205.143]) ([172.28.205.143]) by azsmga001.ch.intel.com with ESMTP; 28 Jun 2013 08:14:36 -0700 Message-ID: <51CDA85B.40503@intel.com> Date: Fri, 28 Jun 2013 15:18:00 -0000 From: Mircea Gherzan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Pedro Alves CC: tromey@redhat.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 7/7] gdbserver: add fallback implementation for memmem References: <1372322622-3216-1-git-send-email-mircea.gherzan@intel.com> <1372322622-3216-8-git-send-email-mircea.gherzan@intel.com> <51CC9097.6000505@redhat.com> In-Reply-To: <51CC9097.6000505@redhat.com> Content-Type: text/plain; charset="iso-8859-1"; format="flowed" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-06/txt/msg00882.txt.bz2 On 27.06.2013 21:20, Pedro Alves wrote: > I'll review the rest of the series later, but ... > > On 06/27/2013 09:43 AM, Mircea Gherzan wrote: >> The memmem() function is a GNU extension. >> >> 2013-06-26 Mircea Gherzan >> >> gdbserver/ >> >> * configure.ac (AC_CHECK_FUNCS): Add memmem. >> * configure: Rebuild. >> * config.in: Rebuild. >> * server.c (memmem): New function, included only if it's not >> already provided by the system. > > We already pull in a fallback memmem from gnulib. You need > to figure out why that isn't working for you. Thanks for pointing this out. Will remove this patch from the series. Mircea --=20 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052