From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Gareth McMullin <gareth@blacksphere.co.nz>, gdb-patches@sourceware.org
Subject: Re: Include putpkt in TRY_CATCH. PR gdb/15275
Date: Tue, 02 Apr 2013 15:24:00 -0000 [thread overview]
Message-ID: <515AE52D.9020403@redhat.com> (raw)
In-Reply-To: <20130329140245.GA16492@host2.jankratochvil.net>
On 03/29/2013 02:02 PM, Jan Kratochvil wrote:
> On Thu, 28 Mar 2013 18:07:10 +0100, Pedro Alves wrote:
>> And detaching should
>> delete breakpoints from the target before sending "D" (although detach
>> command does, a detach caused by "quit" doesn't (if you "gdbserver --attach",
>
> I see it working:
Whoops. I remembered incorrectly where we're removing breakpoints.
>> gdb/
>> 2013-03-28 Pedro Alves <palves@redhat.com>
>>
>> PR gdb/15275
>>
>> * remote.c (send_interrupt_sequence): Use remote_serial_write.
>> (remote_serial_write): New function.
>> (putpkt_binary, getpkt_or_notif_sane_1): Use remote_serial_write.
>
> I agree this fix is better. I will revert the previous check-in after this
> check-in.
Now pushed.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2013-04-02 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw@mail.gmail.com>
2013-03-14 2:02 ` Include putpkt in TRY_CATCH. PR gdb/51275 Gareth McMullin
2013-03-20 17:13 ` Jan Kratochvil
2013-03-21 1:15 ` Gareth McMullin
2013-03-21 8:20 ` Gareth McMullin
2013-03-26 7:27 ` Include putpkt in TRY_CATCH. PR gdb/15275 Jan Kratochvil
2013-03-27 20:17 ` [commit+7.6] " Jan Kratochvil
2013-03-28 20:14 ` Pedro Alves
2013-03-28 21:11 ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-10 19:57 ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" Pedro Alves
2013-03-29 0:44 ` Include putpkt in TRY_CATCH. PR gdb/15275 Gareth McMullin
2013-03-29 16:26 ` Jan Kratochvil
2013-04-02 15:24 ` Pedro Alves [this message]
2013-04-02 15:26 ` Jan Kratochvil
2013-04-09 7:15 ` [PATCH] Avoid potencially-stale errno usage (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-09 8:21 ` Jan Kratochvil
2013-04-09 15:28 ` [commit] Re: [PATCH] Avoid potencially-stale errno usage Pedro Alves
2013-04-11 12:53 ` [patch] " Jan Kratochvil
2013-04-11 16:55 ` Pedro Alves
2013-04-11 22:59 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515AE52D.9020403@redhat.com \
--to=palves@redhat.com \
--cc=gareth@blacksphere.co.nz \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox