From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6012 invoked by alias); 2 Apr 2013 14:03:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5954 invoked by uid 89); 2 Apr 2013 14:03:33 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Apr 2013 14:03:30 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r32E3SVr007871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Apr 2013 10:03:28 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r32E3Pdt018001; Tue, 2 Apr 2013 10:03:26 -0400 Message-ID: <515AE52D.9020403@redhat.com> Date: Tue, 02 Apr 2013 15:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jan Kratochvil CC: Gareth McMullin , gdb-patches@sourceware.org Subject: Re: Include putpkt in TRY_CATCH. PR gdb/15275 References: <20130325195832.GA15218@host2.jankratochvil.net> <515478BE.3030801@redhat.com> <20130329140245.GA16492@host2.jankratochvil.net> In-Reply-To: <20130329140245.GA16492@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00043.txt.bz2 On 03/29/2013 02:02 PM, Jan Kratochvil wrote: > On Thu, 28 Mar 2013 18:07:10 +0100, Pedro Alves wrote: >> And detaching should >> delete breakpoints from the target before sending "D" (although detach >> command does, a detach caused by "quit" doesn't (if you "gdbserver --attach", > > I see it working: Whoops. I remembered incorrectly where we're removing breakpoints. >> gdb/ >> 2013-03-28 Pedro Alves >> >> PR gdb/15275 >> >> * remote.c (send_interrupt_sequence): Use remote_serial_write. >> (remote_serial_write): New function. >> (putpkt_binary, getpkt_or_notif_sane_1): Use remote_serial_write. > > I agree this fix is better. I will revert the previous check-in after this > check-in. Now pushed. Thanks, -- Pedro Alves