From: Gareth McMullin <gareth@blacksphere.co.nz>
To: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Include putpkt in TRY_CATCH. PR gdb/15275
Date: Fri, 29 Mar 2013 00:44:00 -0000 [thread overview]
Message-ID: <CAL8qUbrXomjiUREukyKnP_S73MvfWLi8kUOWbMOZJpHoW=vF6w@mail.gmail.com> (raw)
In-Reply-To: <515478BE.3030801@redhat.com>
On Thu, Mar 28, 2013 at 10:07 AM, Pedro Alves <palves@redhat.com> wrote:
> So, per Gareth's analysis, with tcp, where this is not reproducible,
> we don't error out on sends, but instead detect the error on the
> subsequent readchar. When that read fails, we throw the target away,
> and throw TARGET_CLOSE_ERROR. He was suggesting making ser-unix.c
> fake success too on failed writes, so we'd get to readchar detecting
> the error on serial ports too. But, why not let the error
> propagate out of serial_write, and catch it at the remote level
> instead of delaying the inevitable? IOW, throw away the target
> if writing fails too.
I like this approach, it is a better solution. Thank you.
Gareth
next prev parent reply other threads:[~2013-03-28 22:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw@mail.gmail.com>
2013-03-14 2:02 ` Include putpkt in TRY_CATCH. PR gdb/51275 Gareth McMullin
2013-03-20 17:13 ` Jan Kratochvil
2013-03-21 1:15 ` Gareth McMullin
2013-03-21 8:20 ` Gareth McMullin
2013-03-26 7:27 ` Include putpkt in TRY_CATCH. PR gdb/15275 Jan Kratochvil
2013-03-27 20:17 ` [commit+7.6] " Jan Kratochvil
2013-03-28 20:14 ` Pedro Alves
2013-03-28 21:11 ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-10 19:57 ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" Pedro Alves
2013-03-29 0:44 ` Gareth McMullin [this message]
2013-03-29 16:26 ` Include putpkt in TRY_CATCH. PR gdb/15275 Jan Kratochvil
2013-04-02 15:24 ` Pedro Alves
2013-04-02 15:26 ` Jan Kratochvil
2013-04-09 7:15 ` [PATCH] Avoid potencially-stale errno usage (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-09 8:21 ` Jan Kratochvil
2013-04-09 15:28 ` [commit] Re: [PATCH] Avoid potencially-stale errno usage Pedro Alves
2013-04-11 12:53 ` [patch] " Jan Kratochvil
2013-04-11 16:55 ` Pedro Alves
2013-04-11 22:59 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL8qUbrXomjiUREukyKnP_S73MvfWLi8kUOWbMOZJpHoW=vF6w@mail.gmail.com' \
--to=gareth@blacksphere.co.nz \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox