From: Gareth McMullin <gareth@blacksphere.co.nz>
To: gdb-patches@sourceware.org
Subject: Include putpkt in TRY_CATCH. PR gdb/51275
Date: Thu, 14 Mar 2013 02:02:00 -0000 [thread overview]
Message-ID: <CAL8qUbqjtBKJFJZ6dPS78Zh8Eb3b33U9JXTmn1pS3Le93xt7Rw@mail.gmail.com> (raw)
In-Reply-To: <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw@mail.gmail.com>
If debugging with a remote connection over a serial link and the link is
disconnected, say by disconnecting USB serial port, the GDB quit command no
longer works.
Including the call to putpkt in the TRY_CATCH in remote_get_trace_status
allows the exception to be caught and reported, but still allows GDB to exit
on the quit command.
This fixes bug 15275 and probably 11221 which I believe is the same problem.
gdb:
2013-03-14 Gareth McMullin <gareth@blacksphere.co.nz>
PR gdb/15275
* remote.c (remote_get_trace_status): Include putpkt in TRY_CATCH.
---
diff --git a/gdb/remote.c b/gdb/remote.c
index 21d86f7..29c64c0 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -10695,10 +10695,9 @@ remote_get_trace_status (struct trace_status *ts)
trace_regblock_size = get_remote_arch_state ()->sizeof_g_packet;
- putpkt ("qTStatus");
-
TRY_CATCH (ex, RETURN_MASK_ERROR)
{
+ putpkt ("qTStatus");
p = remote_get_noisy_reply (&target_buf, &target_buf_size);
}
if (ex.reason < 0)
next parent reply other threads:[~2013-03-14 2:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw@mail.gmail.com>
2013-03-14 2:02 ` Gareth McMullin [this message]
2013-03-20 17:13 ` Jan Kratochvil
2013-03-21 1:15 ` Gareth McMullin
2013-03-21 8:20 ` Gareth McMullin
2013-03-26 7:27 ` Include putpkt in TRY_CATCH. PR gdb/15275 Jan Kratochvil
2013-03-27 20:17 ` [commit+7.6] " Jan Kratochvil
2013-03-28 20:14 ` Pedro Alves
2013-03-28 21:11 ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-10 19:57 ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" Pedro Alves
2013-03-29 0:44 ` Include putpkt in TRY_CATCH. PR gdb/15275 Gareth McMullin
2013-03-29 16:26 ` Jan Kratochvil
2013-04-02 15:24 ` Pedro Alves
2013-04-02 15:26 ` Jan Kratochvil
2013-04-09 7:15 ` [PATCH] Avoid potencially-stale errno usage (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-09 8:21 ` Jan Kratochvil
2013-04-09 15:28 ` [commit] Re: [PATCH] Avoid potencially-stale errno usage Pedro Alves
2013-04-11 12:53 ` [patch] " Jan Kratochvil
2013-04-11 16:55 ` Pedro Alves
2013-04-11 22:59 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL8qUbqjtBKJFJZ6dPS78Zh8Eb3b33U9JXTmn1pS3Le93xt7Rw@mail.gmail.com \
--to=gareth@blacksphere.co.nz \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox