Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid potencially-stale errno usage (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275)
Date: Tue, 09 Apr 2013 08:21:00 -0000	[thread overview]
Message-ID: <20130408183434.GA32515@host2.jankratochvil.net> (raw)
In-Reply-To: <51630502.3050109@redhat.com>

On Mon, 08 Apr 2013 19:57:22 +0200, Pedro Alves wrote:
> @@ -7048,14 +7065,11 @@ readchar (int timeout)
>    switch ((enum serial_rc) ch)
>      {
>      case SERIAL_EOF:
> -      remote_unpush_target ();
> -      throw_error (TARGET_CLOSE_ERROR, _("Remote connection closed"));
> +      unpush_and_perror (_("Remote connection closed"));

I do not see why you have changed this part.  I have checked SERIAL_EOF is
returned in cases where errno is not set (errno is unchanged).


Otherwise it looks OK to me.


Thanks,
Jan


  reply	other threads:[~2013-04-08 18:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw@mail.gmail.com>
2013-03-14  2:02 ` Include putpkt in TRY_CATCH. PR gdb/51275 Gareth McMullin
2013-03-20 17:13   ` Jan Kratochvil
2013-03-21  1:15     ` Gareth McMullin
2013-03-21  8:20       ` Gareth McMullin
2013-03-26  7:27   ` Include putpkt in TRY_CATCH. PR gdb/15275 Jan Kratochvil
2013-03-27 20:17     ` [commit+7.6] " Jan Kratochvil
2013-03-28 20:14     ` Pedro Alves
2013-03-28 21:11       ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-10 19:57         ` [PATCH] make -gdb-exit call disconnect_tracing too, and don't lose history if the target errors on "quit" Pedro Alves
2013-03-29  0:44       ` Include putpkt in TRY_CATCH. PR gdb/15275 Gareth McMullin
2013-03-29 16:26       ` Jan Kratochvil
2013-04-02 15:24         ` Pedro Alves
2013-04-02 15:26           ` Jan Kratochvil
2013-04-09  7:15       ` [PATCH] Avoid potencially-stale errno usage (was: Re: Include putpkt in TRY_CATCH. PR gdb/15275) Pedro Alves
2013-04-09  8:21         ` Jan Kratochvil [this message]
2013-04-09 15:28           ` [commit] Re: [PATCH] Avoid potencially-stale errno usage Pedro Alves
2013-04-11 12:53             ` [patch] " Jan Kratochvil
2013-04-11 16:55               ` Pedro Alves
2013-04-11 22:59                 ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408183434.GA32515@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox