[patch]remove whitespace in frame.c

[patch]remove whitespace in frame.c

[asmwarrior]

Hi, this is a simple patch to remove a white space

  gdb/frame.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/frame.c b/gdb/frame.c
index 0821b6e..4b8ab60 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -42,7 +42,7 @@
  #include "gdbthread.h"
  #include "block.h"
  #include "inline-frame.h"
-#include  "tracepoint.h"
+#include "tracepoint.h"
  
  static struct frame_info *get_prev_frame_1 (struct frame_info *this_frame);
  static struct frame_info *get_prev_frame_raw (struct frame_info *this_frame);


Thanks

Yuanhui Zhang

Re: [patch]remove whitespace in frame.c

[Yao Qi]

On 02/15/2013 11:05 PM, asmwarrior wrote:
> diff --git a/gdb/frame.c b/gdb/frame.c
> index 0821b6e..4b8ab60 100644
> --- a/gdb/frame.c
> +++ b/gdb/frame.c
> @@ -42,7 +42,7 @@
>    #include "gdbthread.h"
>    #include "block.h"
>    #include "inline-frame.h"
> -#include  "tracepoint.h"
> +#include "tracepoint.h"
>
>    static struct frame_info *get_prev_frame_1 (struct frame_info *this_frame);
>    static struct frame_info *get_prev_frame_raw (struct frame_info *this_frame);

Yuanhui,
Thanks for doing this.

Change like this is qualified as obvious and can be committed directly. 
  However, we still need a changelog entry.

-- 
Yao (齐尧)

Re: [patch]remove whitespace in frame.c

[asmwarrior]

On 2013-2-16 12:57, Yao Qi wrote:
> On 02/15/2013 11:05 PM, asmwarrior wrote:
>> diff --git a/gdb/frame.c b/gdb/frame.c
>> index 0821b6e..4b8ab60 100644
>> --- a/gdb/frame.c
>> +++ b/gdb/frame.c
>> @@ -42,7 +42,7 @@
>>     #include "gdbthread.h"
>>     #include "block.h"
>>     #include "inline-frame.h"
>> -#include  "tracepoint.h"
>> +#include "tracepoint.h"
>>
>>     static struct frame_info *get_prev_frame_1 (struct frame_info *this_frame);
>>     static struct frame_info *get_prev_frame_raw (struct frame_info *this_frame);
> Yuanhui,
> Thanks for doing this.
>
> Change like this is qualified as obvious and can be committed directly.
>    However, we still need a changelog entry.
>
Hi, Yao, thanks. I do not know what is the correct changelog text format.
I think changelog can be:
Remove one extra white space after #include directive.

Anyway, the patch is too simple and abvious in my original post, so any GDB devs can help to apply it.

Thanks.
Yuanhui Zhang

Re: [patch]remove whitespace in frame.c

[Yao Qi]

On 02/16/2013 03:46 PM, asmwarrior wrote:
> Hi, Yao, thanks. I do not know what is the correct changelog text format.
> I think changelog can be:
> Remove one extra white space after #include directive.
>

The format is not correct.  See more about ChangeLog here
http://www.gnu.org/prep/standards/standards.html#Change-Logs

> Anyway, the patch is too simple and abvious in my original post, so any GDB devs can help to apply it.

Not really :)  The patch is simple, but we still need to know who made 
this change, the name and email address.  Some one may use gmail post 
patches and use his/her employer's email address in ChangeLog.  We don't 
know what name and email address you want to put on ChangeLog.  I find 
your record in ChangeLog-2012, so use it here.

2013-02-16  Yuanhui Zhang  <asmwarrior@gmail.com>

	* frame.c: Remove one extra white space after #include
	directive.

Anyway, since you post patch here, please follow the rules.  Writing a 
changelog entry shouldn't cost you more than ten minutes, so next time, 
please don't forget the changelog entry.  Thanks.

I'll commit this patch for you.

-- 
Yao (齐尧)

Re: [patch]remove whitespace in frame.c

[asmwarrior]

On 2013-2-16 12:57, Yao Qi wrote:
> On 02/15/2013 11:05 PM, asmwarrior wrote:
>> diff --git a/gdb/frame.c b/gdb/frame.c
>> index 0821b6e..4b8ab60 100644
>> --- a/gdb/frame.c
>> +++ b/gdb/frame.c
>> @@ -42,7 +42,7 @@
>>     #include "gdbthread.h"
>>     #include "block.h"
>>     #include "inline-frame.h"
>> -#include  "tracepoint.h"
>> +#include "tracepoint.h"
>>
>>     static struct frame_info *get_prev_frame_1 (struct frame_info *this_frame);
>>     static struct frame_info *get_prev_frame_raw (struct frame_info *this_frame);
>
> Yuanhui,
> Thanks for doing this.
>
> Change like this is qualified as obvious and can be committed directly.
>    However, we still need a changelog entry.
>

I think a simple GDB ARI rule is need to automatically detect such issue. But I don't have the ability to implement such rule.