Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: asmwarrior <asmwarrior@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch]remove whitespace in frame.c
Date: Sat, 16 Feb 2013 08:56:00 -0000	[thread overview]
Message-ID: <511F4991.4070006@codesourcery.com> (raw)
In-Reply-To: <511F3944.4070208@gmail.com>

On 02/16/2013 03:46 PM, asmwarrior wrote:
> Hi, Yao, thanks. I do not know what is the correct changelog text format.
> I think changelog can be:
> Remove one extra white space after #include directive.
>

The format is not correct.  See more about ChangeLog here
http://www.gnu.org/prep/standards/standards.html#Change-Logs

> Anyway, the patch is too simple and abvious in my original post, so any GDB devs can help to apply it.

Not really :)  The patch is simple, but we still need to know who made 
this change, the name and email address.  Some one may use gmail post 
patches and use his/her employer's email address in ChangeLog.  We don't 
know what name and email address you want to put on ChangeLog.  I find 
your record in ChangeLog-2012, so use it here.

2013-02-16  Yuanhui Zhang  <asmwarrior@gmail.com>

	* frame.c: Remove one extra white space after #include
	directive.

Anyway, since you post patch here, please follow the rules.  Writing a 
changelog entry shouldn't cost you more than ten minutes, so next time, 
please don't forget the changelog entry.  Thanks.

I'll commit this patch for you.

-- 
Yao (齐尧)


  reply	other threads:[~2013-02-16  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 15:01 asmwarrior
2013-02-16  4:58 ` Yao Qi
2013-02-16  7:42   ` asmwarrior
2013-02-16  8:56     ` Yao Qi [this message]
2013-02-16  8:24   ` asmwarrior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511F4991.4070006@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=asmwarrior@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox