From: asmwarrior <asmwarrior@gmail.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch]remove whitespace in frame.c
Date: Sat, 16 Feb 2013 08:24:00 -0000 [thread overview]
Message-ID: <511F4315.5010204@gmail.com> (raw)
In-Reply-To: <511F11A3.1010300@codesourcery.com>
On 2013-2-16 12:57, Yao Qi wrote:
> On 02/15/2013 11:05 PM, asmwarrior wrote:
>> diff --git a/gdb/frame.c b/gdb/frame.c
>> index 0821b6e..4b8ab60 100644
>> --- a/gdb/frame.c
>> +++ b/gdb/frame.c
>> @@ -42,7 +42,7 @@
>> #include "gdbthread.h"
>> #include "block.h"
>> #include "inline-frame.h"
>> -#include "tracepoint.h"
>> +#include "tracepoint.h"
>>
>> static struct frame_info *get_prev_frame_1 (struct frame_info *this_frame);
>> static struct frame_info *get_prev_frame_raw (struct frame_info *this_frame);
>
> Yuanhui,
> Thanks for doing this.
>
> Change like this is qualified as obvious and can be committed directly.
> However, we still need a changelog entry.
>
I think a simple GDB ARI rule is need to automatically detect such issue. But I don't have the ability to implement such rule.
prev parent reply other threads:[~2013-02-16 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 15:01 asmwarrior
2013-02-16 4:58 ` Yao Qi
2013-02-16 7:42 ` asmwarrior
2013-02-16 8:56 ` Yao Qi
2013-02-16 8:24 ` asmwarrior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F4315.5010204@gmail.com \
--to=asmwarrior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox