From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10202 invoked by alias); 16 Feb 2013 08:24:25 -0000 Received: (qmail 10156 invoked by uid 22791); 16 Feb 2013 08:24:22 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_SM X-Spam-Check-By: sourceware.org Received: from mail-da0-f50.google.com (HELO mail-da0-f50.google.com) (209.85.210.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Feb 2013 08:24:17 +0000 Received: by mail-da0-f50.google.com with SMTP id h15so1746183dan.37 for ; Sat, 16 Feb 2013 00:24:16 -0800 (PST) X-Received: by 10.66.187.204 with SMTP id fu12mr19276815pac.43.1361003056601; Sat, 16 Feb 2013 00:24:16 -0800 (PST) Received: from [192.168.1.128] ([115.193.204.164]) by mx.google.com with ESMTPS id vq9sm7380902pbc.36.2013.02.16.00.24.13 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Feb 2013 00:24:15 -0800 (PST) Message-ID: <511F4315.5010204@gmail.com> Date: Sat, 16 Feb 2013 08:24:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0a1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [patch]remove whitespace in frame.c References: <511E4EAC.2020602@gmail.com> <511F11A3.1010300@codesourcery.com> In-Reply-To: <511F11A3.1010300@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00432.txt.bz2 On 2013-2-16 12:57, Yao Qi wrote: > On 02/15/2013 11:05 PM, asmwarrior wrote: >> diff --git a/gdb/frame.c b/gdb/frame.c >> index 0821b6e..4b8ab60 100644 >> --- a/gdb/frame.c >> +++ b/gdb/frame.c >> @@ -42,7 +42,7 @@ >> #include "gdbthread.h" >> #include "block.h" >> #include "inline-frame.h" >> -#include "tracepoint.h" >> +#include "tracepoint.h" >> >> static struct frame_info *get_prev_frame_1 (struct frame_info *this_frame); >> static struct frame_info *get_prev_frame_raw (struct frame_info *this_frame); > > Yuanhui, > Thanks for doing this. > > Change like this is qualified as obvious and can be committed directly. > However, we still need a changelog entry. > I think a simple GDB ARI rule is need to automatically detect such issue. But I don't have the ability to implement such rule.