Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Tobler <andreast-list@fgznet.ch>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] revised FreeBSD PowerPC support
Date: Sun, 03 Feb 2013 17:25:00 -0000	[thread overview]
Message-ID: <510E9D77.9000305@fgznet.ch> (raw)
In-Reply-To: <510E8942.8020502@fgznet.ch>

On 03.02.13 16:58, Andreas Tobler wrote:
> Hi Joel,
> 
> On 03.02.13 16:11, Joel Brobecker wrote:
>> Hi Andreas,
>>
>>> 2013-02-01  Andreas Tobler  <andreast@fgznet.ch>
>>>
>>> 	* Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
>>> 	* configure.host: Add powerpc*-*-freebsd* target.
>>> 	* configure.tgt: Add target info for powerpc*-*-freebsd*.
>>> 	* ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
>>> 	* config/powerpc/fbsd.mh: New file.
>>
>> I only quickly scanned your patch, and just happened to notice
>> that the .mh file is missing a copyright header. I know that most
>> .mh files do not have one, and yours is probably small enough that
>> we could get away with it, but we're trying to be a little more
>> consistent about this now. Thank you!
> 
> Np, I was looking at the others and left it away. I'll add one.

Just to make it clear, is the below ok? I see that I'm going to be the
first adding a copyright header :)

Thanks,
Andreas

config/powerpc/fbsd.mh
----
/* Native config information for GDB on PowerPC systems running FreeBSD.

   Copyright (C) 2013 Free Software Foundation, Inc.

   This file is part of GDB.

   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 3 of the License, or
   (at your option) any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o

LOADLIBES= -lkvm

----


  reply	other threads:[~2013-02-03 17:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 21:51 Andreas Tobler
2013-02-03 15:12 ` Joel Brobecker
2013-02-03 15:59   ` Andreas Tobler
2013-02-03 17:25     ` Andreas Tobler [this message]
2013-02-04 16:30       ` Joel Brobecker
2013-02-04 18:13 ` Pedro Alves
2013-02-04 18:59   ` Mark Kettenis
2013-02-04 19:02     ` Andreas Tobler
2013-02-04 19:24       ` Pedro Alves
2013-02-04 20:50         ` Andreas Tobler
2013-02-04 21:41           ` Joel Brobecker
2013-02-04 21:53             ` Andreas Tobler
2013-02-04 21:56               ` Joel Brobecker
2013-02-05  3:42               ` Eli Zaretskii
2013-02-05  6:02                 ` Andreas Tobler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510E9D77.9000305@fgznet.ch \
    --to=andreast-list@fgznet.ch \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox