From: Joel Brobecker <brobecker@adacore.com>
To: Andreas Tobler <andreast-list@fgznet.ch>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] revised FreeBSD PowerPC support
Date: Sun, 03 Feb 2013 15:12:00 -0000 [thread overview]
Message-ID: <20130203151153.GB5265@adacore.com> (raw)
In-Reply-To: <510C38DB.1020407@fgznet.ch>
Hi Andreas,
> 2013-02-01 Andreas Tobler <andreast@fgznet.ch>
>
> * Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
> * configure.host: Add powerpc*-*-freebsd* target.
> * configure.tgt: Add target info for powerpc*-*-freebsd*.
> * ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
> * config/powerpc/fbsd.mh: New file.
I only quickly scanned your patch, and just happened to notice
that the .mh file is missing a copyright header. I know that most
.mh files do not have one, and yours is probably small enough that
we could get away with it, but we're trying to be a little more
consistent about this now. Thank you!
> Index: config/powerpc/fbsd.mh
> --- /dev/null
> +++ config/powerpc/fbsd.mh
> @@ -0,0 +1,5 @@
> +# Host: FreeBSD/powerpc
> +NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o
> +
> +LOADLIBES= -lkvm
> +
--
Joel
next prev parent reply other threads:[~2013-02-03 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 21:51 Andreas Tobler
2013-02-03 15:12 ` Joel Brobecker [this message]
2013-02-03 15:59 ` Andreas Tobler
2013-02-03 17:25 ` Andreas Tobler
2013-02-04 16:30 ` Joel Brobecker
2013-02-04 18:13 ` Pedro Alves
2013-02-04 18:59 ` Mark Kettenis
2013-02-04 19:02 ` Andreas Tobler
2013-02-04 19:24 ` Pedro Alves
2013-02-04 20:50 ` Andreas Tobler
2013-02-04 21:41 ` Joel Brobecker
2013-02-04 21:53 ` Andreas Tobler
2013-02-04 21:56 ` Joel Brobecker
2013-02-05 3:42 ` Eli Zaretskii
2013-02-05 6:02 ` Andreas Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203151153.GB5265@adacore.com \
--to=brobecker@adacore.com \
--cc=andreast-list@fgznet.ch \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox