From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28883 invoked by alias); 3 Feb 2013 15:12:01 -0000 Received: (qmail 28873 invoked by uid 22791); 3 Feb 2013 15:12:00 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Feb 2013 15:11:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 336862E675; Sun, 3 Feb 2013 10:11:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id baemfoiLyWW9; Sun, 3 Feb 2013 10:11:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F23982E673; Sun, 3 Feb 2013 10:11:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3C6F3CCC33; Sun, 3 Feb 2013 07:11:53 -0800 (PST) Date: Sun, 03 Feb 2013 15:12:00 -0000 From: Joel Brobecker To: Andreas Tobler Cc: gdb-patches@sourceware.org Subject: Re: [patch] revised FreeBSD PowerPC support Message-ID: <20130203151153.GB5265@adacore.com> References: <510C38DB.1020407@fgznet.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <510C38DB.1020407@fgznet.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00054.txt.bz2 Hi Andreas, > 2013-02-01 Andreas Tobler > > * Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files. > * configure.host: Add powerpc*-*-freebsd* target. > * configure.tgt: Add target info for powerpc*-*-freebsd*. > * ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files. > * config/powerpc/fbsd.mh: New file. I only quickly scanned your patch, and just happened to notice that the .mh file is missing a copyright header. I know that most .mh files do not have one, and yours is probably small enough that we could get away with it, but we're trying to be a little more consistent about this now. Thank you! > Index: config/powerpc/fbsd.mh > --- /dev/null > +++ config/powerpc/fbsd.mh > @@ -0,0 +1,5 @@ > +# Host: FreeBSD/powerpc > +NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o > + > +LOADLIBES= -lkvm > + -- Joel