From: Andreas Tobler <andreast-list@fgznet.ch>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
palves@redhat.com, Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] revised FreeBSD PowerPC support
Date: Mon, 04 Feb 2013 19:02:00 -0000 [thread overview]
Message-ID: <511005CB.1040306@fgznet.ch> (raw)
In-Reply-To: <201302041859.r14Ix296013414@glazunov.sibelius.xs4all.nl>
On 04.02.13 19:59, Mark Kettenis wrote:
>> Date: Mon, 04 Feb 2013 18:13:38 +0000
>> From: Pedro Alves <palves@redhat.com>
>>
>> On 02/01/2013 09:51 PM, Andreas Tobler wrote:
>>> Index: ./ppcfbsd-tdep.h
>>> --- /dev/null
>>> +++ ./ppcfbsd-tdep.h
>>> @@ -0,0 +1,33 @@
>> ...
>>> +
>>> +/* FreeBSD target descriptions. */
>>> +extern struct target_desc *tdesc_powerpc_32l;
>>> +extern struct target_desc *tdesc_powerpc_64l;
>>
>> These look stale.
>>
>> Otherwise looks good to me.
>
> Didn't spot those. But the diff looks sane to me as well.
>
>
Given the above hint and the one from Joel regarding the mh copyright
with # I take it as ok to commit? If so, do I have to wait or can I
commit immediately? (Branching?)
Thank you all for the comments.
Andreas
next prev parent reply other threads:[~2013-02-04 19:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 21:51 Andreas Tobler
2013-02-03 15:12 ` Joel Brobecker
2013-02-03 15:59 ` Andreas Tobler
2013-02-03 17:25 ` Andreas Tobler
2013-02-04 16:30 ` Joel Brobecker
2013-02-04 18:13 ` Pedro Alves
2013-02-04 18:59 ` Mark Kettenis
2013-02-04 19:02 ` Andreas Tobler [this message]
2013-02-04 19:24 ` Pedro Alves
2013-02-04 20:50 ` Andreas Tobler
2013-02-04 21:41 ` Joel Brobecker
2013-02-04 21:53 ` Andreas Tobler
2013-02-04 21:56 ` Joel Brobecker
2013-02-05 3:42 ` Eli Zaretskii
2013-02-05 6:02 ` Andreas Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511005CB.1040306@fgznet.ch \
--to=andreast-list@fgznet.ch \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox