From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10201 invoked by alias); 4 Feb 2013 19:02:52 -0000 Received: (qmail 10128 invoked by uid 22791); 4 Feb 2013 19:02:49 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Feb 2013 19:02:44 +0000 Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id r14J2Z8e083130; Mon, 4 Feb 2013 20:02:36 +0100 (CET) (envelope-from andreast-list@fgznet.ch) Message-ID: <511005CB.1040306@fgznet.ch> Date: Mon, 04 Feb 2013 19:02:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Mark Kettenis , palves@redhat.com, Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [patch] revised FreeBSD PowerPC support References: <510C38DB.1020407@fgznet.ch> <510FFA52.9090503@redhat.com> <201302041859.r14Ix296013414@glazunov.sibelius.xs4all.nl> In-Reply-To: <201302041859.r14Ix296013414@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00092.txt.bz2 On 04.02.13 19:59, Mark Kettenis wrote: >> Date: Mon, 04 Feb 2013 18:13:38 +0000 >> From: Pedro Alves >> >> On 02/01/2013 09:51 PM, Andreas Tobler wrote: >>> Index: ./ppcfbsd-tdep.h >>> --- /dev/null >>> +++ ./ppcfbsd-tdep.h >>> @@ -0,0 +1,33 @@ >> ... >>> + >>> +/* FreeBSD target descriptions. */ >>> +extern struct target_desc *tdesc_powerpc_32l; >>> +extern struct target_desc *tdesc_powerpc_64l; >> >> These look stale. >> >> Otherwise looks good to me. > > Didn't spot those. But the diff looks sane to me as well. > > Given the above hint and the one from Joel regarding the mh copyright with # I take it as ok to commit? If so, do I have to wait or can I commit immediately? (Branching?) Thank you all for the comments. Andreas