Re: [patch] revised FreeBSD PowerPC support

Andreas Tobler
2013-02-03T17:25:23Z

On 03.02.13 16:58, Andreas Tobler wrote:
> Hi Joel,
>
> On 03.02.13 16:11, Joel Brobecker wrote:
>> Hi Andreas,
>>
>>> 2013-02-01 Andreas Tobler <andreast@fgznet.ch>
>>>
>>> * Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
>>> * configure.host: Add powerpc*-*-freebsd* target.
>>> * configure.tgt: Add target info for powerpc*-*-freebsd*.
>>> * ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
>>> * config/powerpc/fbsd.mh: New file.
>>
>> I only quickly scanned your patch, and just happened to notice
>> that the .mh file is missing a copyright header. I know that most
>> .mh files do not have one, and yours is probably small enough that
>> we could get away with it, but we're trying to be a little more
>> consistent about this now. Thank you!
>
> Np, I was looking at the others and left it away. I'll add one.

Just to make it clear, is the below ok? I see that I'm going to be the
first adding a copyright header :)

Thanks,
Andreas

config/powerpc/fbsd.mh
----
/* Native config information for GDB on PowerPC systems running FreeBSD.

Copyright (C) 2013 Free Software Foundation, Inc.

This file is part of GDB.

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */

NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o

LOADLIBES= -lkvm

----