Re: [patch] revised FreeBSD PowerPC support

Andreas Tobler
2013-02-03T15:59:09Z

Hi Joel,

On 03.02.13 16:11, Joel Brobecker wrote:
> Hi Andreas,
>
>> 2013-02-01 Andreas Tobler <andreast@fgznet.ch>
>>
>> * Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
>> * configure.host: Add powerpc*-*-freebsd* target.
>> * configure.tgt: Add target info for powerpc*-*-freebsd*.
>> * ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
>> * config/powerpc/fbsd.mh: New file.
>
> I only quickly scanned your patch, and just happened to notice
> that the .mh file is missing a copyright header. I know that most
> .mh files do not have one, and yours is probably small enough that
> we could get away with it, but we're trying to be a little more
> consistent about this now. Thank you!

Np, I was looking at the others and left it away. I'll add one.

Thanks, for the feedback!
Andreas

>> Index: config/powerpc/fbsd.mh
>> --- /dev/null
>> +++ config/powerpc/fbsd.mh
>> @@ -0,0 +1,5 @@
>> +# Host: FreeBSD/powerpc
>> +NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o
>> +
>> +LOADLIBES= -lkvm
>> +
>
>