From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17169 invoked by alias); 3 Feb 2013 17:25:23 -0000 Received: (qmail 17142 invoked by uid 22791); 3 Feb 2013 17:25:21 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Feb 2013 17:25:15 +0000 Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id r13HPBEw018185; Sun, 3 Feb 2013 18:25:12 +0100 (CET) (envelope-from andreast-list@fgznet.ch) Message-ID: <510E9D77.9000305@fgznet.ch> Date: Sun, 03 Feb 2013 17:25:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [patch] revised FreeBSD PowerPC support References: <510C38DB.1020407@fgznet.ch> <20130203151153.GB5265@adacore.com> <510E8942.8020502@fgznet.ch> In-Reply-To: <510E8942.8020502@fgznet.ch> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00068.txt.bz2 On 03.02.13 16:58, Andreas Tobler wrote: > Hi Joel, > > On 03.02.13 16:11, Joel Brobecker wrote: >> Hi Andreas, >> >>> 2013-02-01 Andreas Tobler >>> >>> * Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files. >>> * configure.host: Add powerpc*-*-freebsd* target. >>> * configure.tgt: Add target info for powerpc*-*-freebsd*. >>> * ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files. >>> * config/powerpc/fbsd.mh: New file. >> >> I only quickly scanned your patch, and just happened to notice >> that the .mh file is missing a copyright header. I know that most >> .mh files do not have one, and yours is probably small enough that >> we could get away with it, but we're trying to be a little more >> consistent about this now. Thank you! > > Np, I was looking at the others and left it away. I'll add one. Just to make it clear, is the below ok? I see that I'm going to be the first adding a copyright header :) Thanks, Andreas config/powerpc/fbsd.mh ---- /* Native config information for GDB on PowerPC systems running FreeBSD. Copyright (C) 2013 Free Software Foundation, Inc. This file is part of GDB. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see . */ NATDEPFILES= fbsd-nat.o fork-child.o inf-ptrace.o ppcfbsd-nat.o bsd-kvm.o LOADLIBES= -lkvm ----