Re: [10/10] RFC: remove gdb_wait.h

[Pedro Alves <palves@redhat.com>]

On 16-11-2012 17:51, Eli Zaretskii wrote:
>> Date: Fri, 16 Nov 2012 17:27:51 +0000
>> From: Pedro Alves <palves@redhat.com>
>> CC: gdb-patches@sourceware.org

> AFAIU, the first 2 are already available on every Posix platform, see
> this discussion on the emacs-devel list:
> 
>   http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-11/msg00446.html
> 
> The 3rd one seems to be used only on Linux, 

Yeah, it's the third one that many me notice this.  It's Linux/NPTL specific.
Only old systems won't have it.  I'm not even sure how good our support for
LinuxThreads is nowadays.  I occasionally hear about it, but I suppose
maybe even those targets stuck in LinuxThreads already have up-to-date headers.

> so perhaps we could depend on its being in sys/wait.h?

If gnulib replaces it, then it won't be there.  If it doesn't, then the
fallback would be necessary for old systems.  I'd be totally fine with
waiting to hear if someone actually stumbles on this, as the fix is quite
trivial.  I just mention it so it doesn't pass up as an inadvertent change.

>> We could move them to say, common/linux-ptrace.h.  __WALL is already there.
> 
> That's another option.
> 
> Coincidentally, I didn't really object to including the gnulib module,
> I was just saying that it might need to be fixed to DTRT on Windows.

-- 
Pedro Alves