From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1334 invoked by alias); 16 Nov 2012 18:10:10 -0000 Received: (qmail 1307 invoked by uid 22791); 16 Nov 2012 18:10:06 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Nov 2012 18:10:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAGI9x9G015526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 16 Nov 2012 13:09:59 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAGI9vHF000984; Fri, 16 Nov 2012 13:09:58 -0500 Message-ID: <50A68175.6070507@redhat.com> Date: Fri, 16 Nov 2012 18:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Eli Zaretskii CC: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [10/10] RFC: remove gdb_wait.h References: <87obiyzns7.fsf@fleche.redhat.com> <87wqxmwthq.fsf@fleche.redhat.com> <50A67797.7050005@redhat.com> <83d2zd4ery.fsf@gnu.org> In-Reply-To: <83d2zd4ery.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00467.txt.bz2 On 16-11-2012 17:51, Eli Zaretskii wrote: >> Date: Fri, 16 Nov 2012 17:27:51 +0000 >> From: Pedro Alves >> CC: gdb-patches@sourceware.org > AFAIU, the first 2 are already available on every Posix platform, see > this discussion on the emacs-devel list: > > http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-11/msg00446.html > > The 3rd one seems to be used only on Linux, Yeah, it's the third one that many me notice this. It's Linux/NPTL specific. Only old systems won't have it. I'm not even sure how good our support for LinuxThreads is nowadays. I occasionally hear about it, but I suppose maybe even those targets stuck in LinuxThreads already have up-to-date headers. > so perhaps we could depend on its being in sys/wait.h? If gnulib replaces it, then it won't be there. If it doesn't, then the fallback would be necessary for old systems. I'd be totally fine with waiting to hear if someone actually stumbles on this, as the fix is quite trivial. I just mention it so it doesn't pass up as an inadvertent change. >> We could move them to say, common/linux-ptrace.h. __WALL is already there. > > That's another option. > > Coincidentally, I didn't really object to including the gnulib module, > I was just saying that it might need to be fixed to DTRT on Windows. -- Pedro Alves