From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [10/10] RFC: remove gdb_wait.h
Date: Fri, 16 Nov 2012 17:52:00 -0000 [thread overview]
Message-ID: <83d2zd4ery.fsf@gnu.org> (raw)
In-Reply-To: <50A67797.7050005@redhat.com>
> Date: Fri, 16 Nov 2012 17:27:51 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> Assuming sys/wait.h doesn't get replaced on older GNU/Linux systems,
> this loses these bits:
>
> /* For native GNU/Linux we may use waitpid and the __WCLONE option.
> <GRIPE> It is of course dangerous not to use the REAL header file...
> </GRIPE>. */
>
> /* Bits in the third argument to `waitpid'. */
> #ifndef WNOHANG
> #define WNOHANG 1 /* Don't block waiting. */
> #endif
>
> #ifndef WUNTRACED
> #define WUNTRACED 2 /* Report status of stopped children. */
> #endif
>
> #ifndef __WCLONE
> #define __WCLONE 0x80000000 /* Wait for cloned process. */
> #endif
>
> I'm not sure whether we still encounter systems without these, and
> if gdb works on them at all.
AFAIU, the first 2 are already available on every Posix platform, see
this discussion on the emacs-devel list:
http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-11/msg00446.html
The 3rd one seems to be used only on Linux, so perhaps we could
depend on its being in sys/wait.h?
> We could move them to say, common/linux-ptrace.h. __WALL is already there.
That's another option.
Coincidentally, I didn't really object to including the gnulib module,
I was just saying that it might need to be fixed to DTRT on Windows.
next prev parent reply other threads:[~2012-11-16 17:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 19:09 [0/10] RFC: use gnulib more heavily + more configure fixes Tom Tromey
2012-11-15 19:11 ` Tom Tromey
2012-11-15 19:14 ` [1/10] RFC: update gnulib Tom Tromey
2012-11-15 19:19 ` Joel Brobecker
2012-11-15 19:15 ` [0/10] RFC: use gnulib more heavily + more configure fixes Eli Zaretskii
2012-11-15 19:22 ` [3/10] RFC: remove gdb_dirent.h Tom Tromey
2012-11-16 2:46 ` Joel Brobecker
2012-11-27 20:11 ` Tom Tromey
2012-11-15 19:25 ` [4/10] RFC: unconditionally include signal.h Tom Tromey
2012-11-16 17:18 ` Pedro Alves
2012-11-17 1:25 ` Joel Brobecker
2012-11-17 8:15 ` Eli Zaretskii
2012-11-19 15:05 ` Pedro Alves
2012-11-27 20:14 ` Tom Tromey
2012-11-15 19:26 ` [5/10] RFC: don't check for stddef.h Tom Tromey
2012-11-15 19:28 ` [6/10] RFC: don't check for stdlib.h Tom Tromey
2012-11-15 19:29 ` [7/10] RFC: don't check for unistd.h Tom Tromey
2012-11-15 19:31 ` [8/10] RFC: don't check for sys/types.h Tom Tromey
2012-11-15 19:33 ` [9/10] RFC: remove gdb_stat.h Tom Tromey
2012-11-15 19:33 ` [2/10] RFC: remove gdb_string.h Tom Tromey
2012-11-15 20:08 ` Eli Zaretskii
2012-11-15 20:22 ` Tom Tromey
2012-11-15 20:34 ` Eli Zaretskii
2012-11-16 2:42 ` Joel Brobecker
2012-11-15 20:32 ` [10/10] RFC: remove gdb_wait.h Tom Tromey
2012-11-15 20:54 ` Eli Zaretskii
2012-11-15 21:08 ` Joel Brobecker
2012-11-16 8:18 ` Eli Zaretskii
2012-11-16 14:45 ` Joel Brobecker
2012-11-16 15:39 ` Eli Zaretskii
2012-11-16 17:28 ` Pedro Alves
2012-11-16 17:52 ` Eli Zaretskii [this message]
2012-11-16 18:10 ` Pedro Alves
2012-11-16 18:26 ` Eli Zaretskii
2012-11-17 2:30 ` Joel Brobecker
2012-11-19 15:09 ` Pedro Alves
2012-11-16 17:55 ` [0/10] RFC: use gnulib more heavily + more configure fixes Pedro Alves
2012-11-27 21:24 ` Tom Tromey
2012-12-10 20:41 ` Tom Tromey
2012-12-11 3:11 ` Joel Brobecker
2012-12-11 10:53 ` Pedro Alves
2012-12-17 19:39 ` Tom Tromey
2013-01-03 18:25 ` Tom Tromey
2013-01-03 18:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d2zd4ery.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox