From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [2/10] RFC: remove gdb_string.h
Date: Fri, 16 Nov 2012 02:42:00 -0000 [thread overview]
Message-ID: <20121116024241.GI3790@adacore.com> (raw)
In-Reply-To: <87vcd6y8pm.fsf@fleche.redhat.com>
> The bulk of this patch is just changing "gdb_string.h" to <string.h>.
>
> I dropped the auto-generated bits from this patch, but not the #include
> changes.
[...]
>
> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add string,
> strerror, and strstr.
> * common/gdb_string.h: Remove.
> * configure.ac: Don't check for string.h, memory.h, strings.h,
> strerror, or strstr.
> * config.in: Rebuild.
> * configure: Rebuild.
> * gnulib/aclocal.m4: Update.
> * gnulib/configure: Update.
> * gnulib/import/Makefile.am: Update.
> * gnulib/import/Makefile.in: Update.
> * gnulib/import/errno.in.h: Update.
> * gnulib/import/intprops.h: Update.
> * gnulib/import/m4/errno_h.m4: Update.
> * gnulib/import/m4/gnulib-cache.m4: Update.
> * gnulib/import/m4/gnulib-comp.m4: Update.
> * gnulib/import/m4/strerror.m4: Update.
> * gnulib/import/m4/strstr.m4: Update.
> * gnulib/import/m4/sys_socket_h.m4: Update.
> * gnulib/import/strerror-override.c: Update.
> * gnulib/import/strerror-override.h: Update.
> * gnulib/import/strerror.c: Update.
> * gnulib/import/strstr.c: Update.
>
> * ada-exp.y: Update.
> * ada-lang.c: Update.
> * ada-lex.l: Update.
> * ada-typeprint.c: Update.
> * ada-valprint.c: Update.
> * aix-thread.c: Update.
> * alpha-linux-tdep.c: Update.
> * alpha-mdebug-tdep.c: Update.
> * alpha-nat.c: Update.
> * alpha-osf1-tdep.c: Update.
> * alpha-tdep.c: Update.
> * alphanbsd-tdep.c: Update.
> * amd64-dicos-tdep.c: Update.
> * amd64-linux-nat.c: Update.
> * amd64-linux-tdep.c: Update.
> * amd64-nat.c: Update.
> * amd64-sol2-tdep.c: Update.
> * amd64fbsd-tdep.c: Update.
> * amd64obsd-tdep.c: Update.
> * arch-utils.c: Update.
> * arm-linux-nat.c: Update.
> * arm-linux-tdep.c: Update.
> * arm-tdep.c: Update.
> * arm-wince-tdep.c: Update.
> * armbsd-tdep.c: Update.
> * armnbsd-nat.c: Update.
> * armnbsd-tdep.c: Update.
> * armobsd-tdep.c: Update.
> * avr-tdep.c: Update.
> * ax-gdb.c: Update.
> * ax-general.c: Update.
> * bcache.c: Update.
> * bfin-tdep.c: Update.
> * breakpoint.c: Update.
> * buildsym.c: Update.
> * c-exp.y: Update.
> * c-lang.c: Update.
> * c-typeprint.c: Update.
> * c-valprint.c: Update.
> * charset.c: Update.
> * cli-out.c: Update.
> * cli/cli-cmds.c: Update.
> * cli/cli-decode.c: Update.
> * cli/cli-dump.c: Update.
> * cli/cli-interp.c: Update.
> * cli/cli-logging.c: Update.
> * cli/cli-script.c: Update.
> * cli/cli-setshow.c: Update.
> * cli/cli-utils.c: Update.
> * coffread.c: Update.
> * common/linux-procfs.c: Update.
> * common/linux-ptrace.c: Update.
> * common/signals.c: Update.
> * common/vec.h: Update.
> * core-regset.c: Update.
> * corefile.c: Update.
> * corelow.c: Update.
> * cp-abi.c: Update.
> * cp-support.c: Update.
> * cp-valprint.c: Update.
> * cris-tdep.c: Update.
> * d-lang.c: Update.
> * dbxread.c: Update.
> * dcache.c: Update.
> * demangle.c: Update.
> * dicos-tdep.c: Update.
> * disasm.c: Update.
> * doublest.c: Update.
> * dsrec.c: Update.
> * dummy-frame.c: Update.
> * dwarf2-frame.c: Update.
> * dwarf2loc.c: Update.
> * dwarf2read.c: Update.
> * elfread.c: Update.
> * environ.c: Update.
> * eval.c: Update.
> * event-loop.c: Update.
> * exceptions.c: Update.
> * exec.c: Update.
> * expprint.c: Update.
> * f-exp.y: Update.
> * f-lang.c: Update.
> * f-typeprint.c: Update.
> * f-valprint.c: Update.
> * fbsd-nat.c: Update.
> * findcmd.c: Update.
> * findvar.c: Update.
> * fork-child.c: Update.
> * frame.c: Update.
> * frv-linux-tdep.c: Update.
> * frv-tdep.c: Update.
> * gdb.c: Update.
> * gdb_bfd.c: Update.
> * gdbarch.c: Update.
> * gdbserver/gdbreplay.c: Update.
> * gdbserver/server.h: Update.
> * gdbtypes.c: Update.
> * gnu-nat.c: Update.
> * gnu-v2-abi.c: Update.
> * gnu-v3-abi.c: Update.
> * go-exp.y: Update.
> * go-lang.c: Update.
> * go32-nat.c: Update.
> * hppa-hpux-tdep.c: Update.
> * hppa-linux-nat.c: Update.
> * hppanbsd-tdep.c: Update.
> * hppaobsd-tdep.c: Update.
> * i386-cygwin-tdep.c: Update.
> * i386-dicos-tdep.c: Update.
> * i386-linux-nat.c: Update.
> * i386-linux-tdep.c: Update.
> * i386-nto-tdep.c: Update.
> * i386-sol2-tdep.c: Update.
> * i386-tdep.c: Update.
> * i386bsd-tdep.c: Update.
> * i386gnu-nat.c: Update.
> * i386nbsd-tdep.c: Update.
> * i386obsd-tdep.c: Update.
> * i387-tdep.c: Update.
> * ia64-libunwind-tdep.c: Update.
> * ia64-linux-nat.c: Update.
> * inf-child.c: Update.
> * inf-ptrace.c: Update.
> * inf-ttrace.c: Update.
> * infcall.c: Update.
> * infcmd.c: Update.
> * inflow.c: Update.
> * infrun.c: Update.
> * interps.c: Update.
> * iq2000-tdep.c: Update.
> * irix5-nat.c: Update.
> * jv-exp.y: Update.
> * jv-lang.c: Update.
> * jv-typeprint.c: Update.
> * jv-valprint.c: Update.
> * language.c: Update.
> * linux-fork.c: Update.
> * linux-nat.c: Update.
> * lm32-tdep.c: Update.
> * m2-exp.y: Update.
> * m2-typeprint.c: Update.
> * m32c-tdep.c: Update.
> * m32r-linux-nat.c: Update.
> * m32r-linux-tdep.c: Update.
> * m32r-rom.c: Update.
> * m32r-tdep.c: Update.
> * m68hc11-tdep.c: Update.
> * m68k-tdep.c: Update.
> * m68kbsd-tdep.c: Update.
> * m68klinux-nat.c: Update.
> * m68klinux-tdep.c: Update.
> * m88k-tdep.c: Update.
> * macrocmd.c: Update.
> * main.c: Update.
> * mdebugread.c: Update.
> * mem-break.c: Update.
> * memattr.c: Update.
> * memory-map.c: Update.
> * mep-tdep.c: Update.
> * mi/mi-cmd-break.c: Update.
> * mi/mi-cmd-disas.c: Update.
> * mi/mi-cmd-env.c: Update.
> * mi/mi-cmd-stack.c: Update.
> * mi/mi-cmd-var.c: Update.
> * mi/mi-cmds.c: Update.
> * mi/mi-console.c: Update.
> * mi/mi-getopt.c: Update.
> * mi/mi-interp.c: Update.
> * mi/mi-main.c: Update.
> * mi/mi-parse.c: Update.
> * microblaze-rom.c: Update.
> * microblaze-tdep.c: Update.
> * mingw-hdep.c: Update.
> * minsyms.c: Update.
> * mips-irix-tdep.c: Update.
> * mips-linux-tdep.c: Update.
> * mips-tdep.c: Update.
> * mips64obsd-tdep.c: Update.
> * mipsnbsd-tdep.c: Update.
> * mipsread.c: Update.
> * mn10300-linux-tdep.c: Update.
> * mn10300-tdep.c: Update.
> * monitor.c: Update.
> * moxie-tdep.c: Update.
> * mt-tdep.c: Update.
> * nbsd-tdep.c: Update.
> * nto-procfs.c: Update.
> * nto-tdep.c: Update.
> * objc-lang.c: Update.
> * objfiles.c: Update.
> * opencl-lang.c: Update.
> * osabi.c: Update.
> * osdata.c: Update.
> * p-exp.y: Update.
> * p-lang.c: Update.
> * p-typeprint.c: Update.
> * parse.c: Update.
> * posix-hdep.c: Update.
> * ppc-linux-nat.c: Update.
> * ppc-sysv-tdep.c: Update.
> * ppcnbsd-tdep.c: Update.
> * ppcobsd-tdep.c: Update.
> * printcmd.c: Update.
> * procfs.c: Update.
> * prologue-value.c: Update.
> * python/py-auto-load.c: Update.
> * python/py-gdb-readline.c: Update.
> * ravenscar-thread.c: Update.
> * regcache.c: Update.
> * registry.c: Update.
> * remote-fileio.c: Update.
> * remote-m32r-sdi.c: Update.
> * remote-mips.c: Update.
> * remote-sim.c: Update.
> * remote.c: Update.
> * reverse.c: Update.
> * rs6000-aix-tdep.c: Update.
> * ser-base.c: Update.
> * ser-go32.c: Update.
> * ser-mingw.c: Update.
> * ser-pipe.c: Update.
> * ser-tcp.c: Update.
> * ser-unix.c: Update.
> * serial.c: Update.
> * sh-tdep.c: Update.
> * sh64-tdep.c: Update.
> * shnbsd-tdep.c: Update.
> * skip.c: Update.
> * sol-thread.c: Update.
> * solib-dsbt.c: Update.
> * solib-frv.c: Update.
> * solib-osf.c: Update.
> * solib-spu.c: Update.
> * solib-sunos.c: Update.
> * solib-target.c: Update.
> * solib.c: Update.
> * somread.c: Update.
> * source.c: Update.
> * sparc-nat.c: Update.
> * sparc-sol2-tdep.c: Update.
> * sparc-tdep.c: Update.
> * sparc64-tdep.c: Update.
> * sparc64fbsd-tdep.c: Update.
> * sparc64nbsd-tdep.c: Update.
> * sparcnbsd-tdep.c: Update.
> * spu-linux-nat.c: Update.
> * spu-multiarch.c: Update.
> * spu-tdep.c: Update.
> * stabsread.c: Update.
> * stack.c: Update.
> * std-regs.c: Update.
> * symfile.c: Update.
> * symmisc.c: Update.
> * symtab.c: Update.
> * target.c: Update.
> * thread.c: Update.
> * tilegx-linux-nat.c: Update.
> * tilegx-tdep.c: Update.
> * top.c: Update.
> * tracepoint.c: Update.
> * tui/tui-command.c: Update.
> * tui/tui-data.c: Update.
> * tui/tui-disasm.c: Update.
> * tui/tui-file.c: Update.
> * tui/tui-layout.c: Update.
> * tui/tui-out.c: Update.
> * tui/tui-regs.c: Update.
> * tui/tui-source.c: Update.
> * tui/tui-stack.c: Update.
> * tui/tui-win.c: Update.
> * tui/tui-windata.c: Update.
> * tui/tui-winsource.c: Update.
> * typeprint.c: Update.
> * ui-file.c: Update.
> * ui-out.c: Update.
> * user-regs.c: Update.
> * utils.c: Update.
> * v850-tdep.c: Update.
> * valarith.c: Update.
> * valops.c: Update.
> * valprint.c: Update.
> * value.c: Update.
> * varobj.c: Update.
> * vax-tdep.c: Update.
> * vaxnbsd-tdep.c: Update.
> * vaxobsd-tdep.c: Update.
> * windows-nat.c: Update.
> * xcoffread.c: Update.
> * xml-support.c: Update.
> * xstormy16-tdep.c: Update.
> * xtensa-linux-nat.c: Update.
>
> * configure.ac: Don't check for string.h, strerror, strstr.
> * config.in: Rebuild.
> * configure: Rebuild.
Thanks again for doing that, Tom.
FWIW: I went through the patch, and it looks good to me. If it was
tested independintly of the rest of the patch series, it can go in
on its own.
Just one note: It does seem to me as if the strerror and strstr
changes could each have been submitted independently, no? It's
hardly worth the effort now, so not to worry. It would have made
the review of these specific bits a little easier, though, as
these patches would have been pretty small, I think.
--
Joel
next prev parent reply other threads:[~2012-11-16 2:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 19:09 [0/10] RFC: use gnulib more heavily + more configure fixes Tom Tromey
2012-11-15 19:11 ` Tom Tromey
2012-11-15 19:14 ` [1/10] RFC: update gnulib Tom Tromey
2012-11-15 19:19 ` Joel Brobecker
2012-11-15 19:15 ` [0/10] RFC: use gnulib more heavily + more configure fixes Eli Zaretskii
2012-11-15 19:22 ` [3/10] RFC: remove gdb_dirent.h Tom Tromey
2012-11-16 2:46 ` Joel Brobecker
2012-11-27 20:11 ` Tom Tromey
2012-11-15 19:25 ` [4/10] RFC: unconditionally include signal.h Tom Tromey
2012-11-16 17:18 ` Pedro Alves
2012-11-17 1:25 ` Joel Brobecker
2012-11-17 8:15 ` Eli Zaretskii
2012-11-19 15:05 ` Pedro Alves
2012-11-27 20:14 ` Tom Tromey
2012-11-15 19:26 ` [5/10] RFC: don't check for stddef.h Tom Tromey
2012-11-15 19:28 ` [6/10] RFC: don't check for stdlib.h Tom Tromey
2012-11-15 19:29 ` [7/10] RFC: don't check for unistd.h Tom Tromey
2012-11-15 19:31 ` [8/10] RFC: don't check for sys/types.h Tom Tromey
2012-11-15 19:33 ` [9/10] RFC: remove gdb_stat.h Tom Tromey
2012-11-15 19:33 ` [2/10] RFC: remove gdb_string.h Tom Tromey
2012-11-15 20:08 ` Eli Zaretskii
2012-11-15 20:22 ` Tom Tromey
2012-11-15 20:34 ` Eli Zaretskii
2012-11-16 2:42 ` Joel Brobecker [this message]
2012-11-15 20:32 ` [10/10] RFC: remove gdb_wait.h Tom Tromey
2012-11-15 20:54 ` Eli Zaretskii
2012-11-15 21:08 ` Joel Brobecker
2012-11-16 8:18 ` Eli Zaretskii
2012-11-16 14:45 ` Joel Brobecker
2012-11-16 15:39 ` Eli Zaretskii
2012-11-16 17:28 ` Pedro Alves
2012-11-16 17:52 ` Eli Zaretskii
2012-11-16 18:10 ` Pedro Alves
2012-11-16 18:26 ` Eli Zaretskii
2012-11-17 2:30 ` Joel Brobecker
2012-11-19 15:09 ` Pedro Alves
2012-11-16 17:55 ` [0/10] RFC: use gnulib more heavily + more configure fixes Pedro Alves
2012-11-27 21:24 ` Tom Tromey
2012-12-10 20:41 ` Tom Tromey
2012-12-11 3:11 ` Joel Brobecker
2012-12-11 10:53 ` Pedro Alves
2012-12-17 19:39 ` Tom Tromey
2013-01-03 18:25 ` Tom Tromey
2013-01-03 18:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116024241.GI3790@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox