Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support

[Yufeng Zhang <Yufeng.Zhang@arm.com>]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

On 10/17/12 16:17, Pedro Alves wrote:
> On 10/12/2012 09:57 AM, Yufeng Zhang wrote:
>>
>> +if {[skip_shlib_tests]} {
>> +    untested ctxobj.exp
>> +    return -1
>> +}
>
> See<http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.
>
> "In untested calls, please spell out the reason the test ends up untested, instead
> of just writing the test name, as with the latter we just end up with the test name
> duplicated in the gdb.sum output. For example: "
>
> But in these skip_ *cases, I think we can just be silent.  The vast majority of
> the skip_* calls in the testsuite agrees (e.g., seen
> with 'grep -rn "skip_" -A 3 | grep untested').
>
> IOW, this is OK with the untested calls removed.

Thanks!

I've removed the untested calls; the updated patch has been committed
http://sourceware.org/ml/gdb-cvs/2012-10/msg00077.html.

Thanks,
Yufeng

[-- Attachment #2: skip-shared-lib-tests.patch.v2 --]
[-- Type: text/plain, Size: 1498 bytes --]

diff --git a/gdb/testsuite/gdb.base/ctxobj.exp b/gdb/testsuite/gdb.base/ctxobj.exp
index b41ed38..a0eceb7 100644
--- a/gdb/testsuite/gdb.base/ctxobj.exp
+++ b/gdb/testsuite/gdb.base/ctxobj.exp
@@ -13,6 +13,10 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+if {[skip_shlib_tests]} {
+    return -1
+}
+
 set executable ctxobj-m
 
 # The sources used to build two shared libraries (SO).  We use the exact
diff --git a/gdb/testsuite/gdb.base/print-file-var.exp b/gdb/testsuite/gdb.base/print-file-var.exp
index 994abc4..03a2832 100644
--- a/gdb/testsuite/gdb.base/print-file-var.exp
+++ b/gdb/testsuite/gdb.base/print-file-var.exp
@@ -13,6 +13,10 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+if {[skip_shlib_tests]} {
+    return -1
+}
+
 set executable print-file-var-main
 
 set lib1 "print-file-var-lib1"
diff --git a/gdb/testsuite/gdb.base/type-opaque.exp b/gdb/testsuite/gdb.base/type-opaque.exp
index f91c24b..ffd4662 100644
--- a/gdb/testsuite/gdb.base/type-opaque.exp
+++ b/gdb/testsuite/gdb.base/type-opaque.exp
@@ -15,6 +15,10 @@
 
 # Test resolving of an opaque type from the loaded shared library.
 
+if {[skip_shlib_tests]} {
+    return -1
+}
+
 set testfile type-opaque-main
 set libfile type-opaque-lib
 set srcfile ${testfile}.c