From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2151 invoked by alias); 19 Oct 2012 09:14:21 -0000 Received: (qmail 2137 invoked by uid 22791); 19 Oct 2012 09:14:20 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_TX X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Oct 2012 09:14:13 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 19 Oct 2012 10:14:11 +0100 Received: from [10.1.69.62] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 19 Oct 2012 10:14:10 +0100 Message-ID: <508119E2.8040209@arm.com> Date: Fri, 19 Oct 2012 09:14:00 -0000 From: Yufeng Zhang User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support References: <5077DB83.8060504@arm.com> <507ECC26.3060400@redhat.com> In-Reply-To: <507ECC26.3060400@redhat.com> X-MC-Unique: 112101910141114201 Content-Type: multipart/mixed; boundary="------------080004060909070704080506" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00346.txt.bz2 This is a multi-part message in MIME format. --------------080004060909070704080506 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Content-length: 854 On 10/17/12 16:17, Pedro Alves wrote: > On 10/12/2012 09:57 AM, Yufeng Zhang wrote: >> >> +if {[skip_shlib_tests]} { >> + untested ctxobj.exp >> + return -1 >> +} > > See. > > "In untested calls, please spell out the reason the test ends up untested= , instead > of just writing the test name, as with the latter we just end up with the= test name > duplicated in the gdb.sum output. For example: " > > But in these skip_ *cases, I think we can just be silent. The vast major= ity of > the skip_* calls in the testsuite agrees (e.g., seen > with 'grep -rn "skip_" -A 3 | grep untested'). > > IOW, this is OK with the untested calls removed. Thanks! I've removed the untested calls; the updated patch has been committed http://sourceware.org/ml/gdb-cvs/2012-10/msg00077.html. Thanks, Yufeng= --------------080004060909070704080506 Content-Type: text/plain; name=skip-shared-lib-tests.patch.v2 Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="skip-shared-lib-tests.patch.v2" Content-length: 1474 diff --git a/gdb/testsuite/gdb.base/ctxobj.exp b/gdb/testsuite/gdb.base/ctx= obj.exp index b41ed38..a0eceb7 100644 --- a/gdb/testsuite/gdb.base/ctxobj.exp +++ b/gdb/testsuite/gdb.base/ctxobj.exp @@ -13,6 +13,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . */ =20 +if {[skip_shlib_tests]} { + return -1 +} + set executable ctxobj-m =20 # The sources used to build two shared libraries (SO). We use the exact diff --git a/gdb/testsuite/gdb.base/print-file-var.exp b/gdb/testsuite/gdb.= base/print-file-var.exp index 994abc4..03a2832 100644 --- a/gdb/testsuite/gdb.base/print-file-var.exp +++ b/gdb/testsuite/gdb.base/print-file-var.exp @@ -13,6 +13,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . */ =20 +if {[skip_shlib_tests]} { + return -1 +} + set executable print-file-var-main =20 set lib1 "print-file-var-lib1" diff --git a/gdb/testsuite/gdb.base/type-opaque.exp b/gdb/testsuite/gdb.bas= e/type-opaque.exp index f91c24b..ffd4662 100644 --- a/gdb/testsuite/gdb.base/type-opaque.exp +++ b/gdb/testsuite/gdb.base/type-opaque.exp @@ -15,6 +15,10 @@ =20 # Test resolving of an opaque type from the loaded shared library. =20 +if {[skip_shlib_tests]} { + return -1 +} + set testfile type-opaque-main set libfile type-opaque-lib set srcfile ${testfile}.c= --------------080004060909070704080506--