Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yufeng Zhang <Yufeng.Zhang@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support
Date: Wed, 17 Oct 2012 15:18:00 -0000	[thread overview]
Message-ID: <507ECC26.3060400@redhat.com> (raw)
In-Reply-To: <5077DB83.8060504@arm.com>

On 10/12/2012 09:57 AM, Yufeng Zhang wrote:
>  
> +if {[skip_shlib_tests]} {
> +    untested ctxobj.exp
> +    return -1
> +}

See <http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.

"In untested calls, please spell out the reason the test ends up untested, instead
of just writing the test name, as with the latter we just end up with the test name
duplicated in the gdb.sum output. For example: "

But in these skip_ *cases, I think we can just be silent.  The vast majority of
the skip_* calls in the testsuite agrees (e.g., seen
with 'grep -rn "skip_" -A 3 | grep untested').

IOW, this is OK with the untested calls removed.

Thanks.

-- 
Pedro Alves


  parent reply	other threads:[~2012-10-17 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12  8:57 Yufeng Zhang
2012-10-17  8:19 ` Yufeng Zhang
2012-10-17 15:18 ` Pedro Alves [this message]
2012-10-19  9:14   ` Yufeng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507ECC26.3060400@redhat.com \
    --to=palves@redhat.com \
    --cc=Yufeng.Zhang@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox