From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23359 invoked by alias); 17 Oct 2012 15:18:12 -0000 Received: (qmail 23351 invoked by uid 22791); 17 Oct 2012 15:18:11 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 15:18:02 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HFHxKZ012597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Oct 2012 11:17:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9HFHwOu002606; Wed, 17 Oct 2012 11:17:59 -0400 Message-ID: <507ECC26.3060400@redhat.com> Date: Wed, 17 Oct 2012 15:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Yufeng Zhang CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support References: <5077DB83.8060504@arm.com> In-Reply-To: <5077DB83.8060504@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00275.txt.bz2 On 10/12/2012 09:57 AM, Yufeng Zhang wrote: > > +if {[skip_shlib_tests]} { > + untested ctxobj.exp > + return -1 > +} See . "In untested calls, please spell out the reason the test ends up untested, instead of just writing the test name, as with the latter we just end up with the test name duplicated in the gdb.sum output. For example: " But in these skip_ *cases, I think we can just be silent. The vast majority of the skip_* calls in the testsuite agrees (e.g., seen with 'grep -rn "skip_" -A 3 | grep untested'). IOW, this is OK with the untested calls removed. Thanks. -- Pedro Alves