Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yufeng Zhang <Yufeng.Zhang@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] add skip_shlib_tests guard to tests that require shared lib support
Date: Fri, 12 Oct 2012 08:57:00 -0000	[thread overview]
Message-ID: <5077DB83.8060504@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Hi,

This patch adds checks to 3 gdb tests to skip the testing if 
skip_shlib_tests returns 1.

Is it OK to commit?


Thanks,
Yufeng


testsuite/ChangeLog

2012-10-12  Yufeng Zhang  <yufeng.zhang@arm.com>

         * gdb.base/ctxobj.exp: Skip if skip_shlib_tests returns 1.
         * gdb.base/print-file-var.exp: Likewise.
         * gdb.base/type-opaque.exp: Likewise.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: skip-shared-lib-tests.patch --]
[-- Type: text/x-patch; name=skip-shared-lib-tests.patch, Size: 1589 bytes --]

diff --git a/gdb/testsuite/gdb.base/ctxobj.exp b/gdb/testsuite/gdb.base/ctxobj.exp
index b41ed38..529b684 100644
--- a/gdb/testsuite/gdb.base/ctxobj.exp
+++ b/gdb/testsuite/gdb.base/ctxobj.exp
@@ -13,6 +13,11 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+if {[skip_shlib_tests]} {
+    untested ctxobj.exp
+    return -1
+}
+
 set executable ctxobj-m
 
 # The sources used to build two shared libraries (SO).  We use the exact
diff --git a/gdb/testsuite/gdb.base/print-file-var.exp b/gdb/testsuite/gdb.base/print-file-var.exp
index 994abc4..ccde933 100644
--- a/gdb/testsuite/gdb.base/print-file-var.exp
+++ b/gdb/testsuite/gdb.base/print-file-var.exp
@@ -13,6 +13,11 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+if {[skip_shlib_tests]} {
+    untested print-file-var.exp
+    return -1
+}
+
 set executable print-file-var-main
 
 set lib1 "print-file-var-lib1"
diff --git a/gdb/testsuite/gdb.base/type-opaque.exp b/gdb/testsuite/gdb.base/type-opaque.exp
index f91c24b..75b1db0 100644
--- a/gdb/testsuite/gdb.base/type-opaque.exp
+++ b/gdb/testsuite/gdb.base/type-opaque.exp
@@ -15,6 +15,11 @@
 
 # Test resolving of an opaque type from the loaded shared library.
 
+if {[skip_shlib_tests]} {
+    untested type-opaque.exp
+    return -1
+}
+
 set testfile type-opaque-main
 set libfile type-opaque-lib
 set srcfile ${testfile}.c

             reply	other threads:[~2012-10-12  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12  8:57 Yufeng Zhang [this message]
2012-10-17  8:19 ` Yufeng Zhang
2012-10-17 15:18 ` Pedro Alves
2012-10-19  9:14   ` Yufeng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5077DB83.8060504@arm.com \
    --to=yufeng.zhang@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox