From: Pedro Alves <palves@redhat.com>
To: Michael Eager <eager@eagerm.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: MIPS Linux signals
Date: Tue, 22 May 2012 22:06:00 -0000 [thread overview]
Message-ID: <4FBC0DCA.2060706@redhat.com> (raw)
In-Reply-To: <4FBBE9AC.5030200@eagerm.com>
On 05/22/2012 08:31 PM, Michael Eager wrote:
>>
>> All other signal numbers you pass to target_signal_from_host will end up
>> as TARGET_SIGNAL_UNKNOWN, due to the bunch of #ifdef SIGFOO bits in
>> common/signals. Obviously, in most cases, this translation will
>> be wrong. But the point to be taken is, target_signal_from_host _always_
>> translates the signal number passed as argument as if it was a host
>> signal number, no matter what the target really is.
>
> I think the point is that a target signal number should
> always be treated as if it were from a target, never
> that it was from the host.
The discussion on the table is not about what should or not should
be design wise. The discussion is about the confusing
target_signal_from_host method name. I've given ample explanation of
why that should have "host" in its name. If we should eliminate that
function and instead provide gdbarch mappings for all targets or not is
a different discussion. The fact remains that target_signal_from_host
exists, and is widely used. I'd very much like to retain "host" in its
name to remind the reader that while it exists, its implementation really
is just a mapping from the host signals. I'm now pretty much done with
repeating the arguments.
> target signal number should always be treated as if it were from a target,
That requires GDB hardcoding signal mappings, and that's what the gdbarch
hook is for. And that's why I proposed renaming it:
http://sourceware.org/ml/gdb-patches/2012-05/msg00839.html
--
Pedro Alves
next prev parent reply other threads:[~2012-05-22 22:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 2:03 Michael Eager
2012-05-21 11:04 ` Pedro Alves
2012-05-21 14:51 ` Michael Eager
2012-05-21 17:37 ` Pedro Alves
2012-05-21 18:06 ` Michael Eager
2012-05-21 18:19 ` Maciej W. Rozycki
[not found] ` <alpine.DEB.1.10.1205211232260.11227@tp.orcam.me.uk>
2012-05-21 18:21 ` Michael Eager
2012-05-21 22:34 ` Maciej W. Rozycki
2012-05-22 9:38 ` Pedro Alves
2012-05-21 21:35 ` Pedro Alves
2012-05-21 21:53 ` Michael Eager
2012-05-21 22:48 ` Maciej W. Rozycki
2012-05-22 0:16 ` Michael Eager
2012-05-22 10:17 ` Pedro Alves
2012-05-22 13:16 ` Maciej W. Rozycki
2012-05-22 13:32 ` Pedro Alves
2012-05-22 15:10 ` Move store_waitstatus to inf-child.c (was: Re: MIPS Linux signals) Pedro Alves
2012-05-22 15:40 ` MIPS Linux signals Michael Eager
2012-05-22 16:02 ` Pedro Alves
2012-05-22 18:14 ` Michael Eager
2012-05-22 18:31 ` Pedro Alves
2012-05-22 19:32 ` Michael Eager
2012-05-22 22:06 ` Pedro Alves [this message]
2012-05-22 16:26 ` Pedro Alves
2012-05-22 10:58 ` Pedro Alves
2012-05-22 19:31 ` Aleksandar Ristovski
2012-05-22 21:55 ` Pedro Alves
2012-05-22 23:29 ` Aleksandar Ristovski
2012-05-23 11:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC0DCA.2060706@redhat.com \
--to=palves@redhat.com \
--cc=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox