Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Michael Eager <eager@eagerm.com>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: MIPS Linux signals
Date: Tue, 22 May 2012 13:32:00 -0000	[thread overview]
Message-ID: <4FBB9546.5040505@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1205221409250.11227@tp.orcam.me.uk>

On 05/22/2012 02:16 PM, Maciej W. Rozycki wrote:

> On Tue, 22 May 2012, Pedro Alves wrote:
> 
>> > So I think that to sort all of this out, we should:
>> > 
>> > enum target_signal => enum gdb_signal
>> > 
>> > target_signal_from_host => gdb_signal_from_host (or gdb_signal_from_host_signal)
>> > target_signal_to_host => gdb_signal_to_host (or gdb_signal_to_host_signal)
>> > 
>> > gdbarch_target_signal_from_host => gdbarch_gdb_signal_from_target (or gdbarch_gdb_signal_from_target_signal)
>> > gdbarch_target_signal_to_host => gdbarch_gdb_signal_to_target (or gdbarch_gdb_signal_to_target_signal)
>  How about we call the context of the signal "inferior" here and therefore 
> avoid the confusion which target is the host and which host is the target 
> altogether?  I.e.:
> 
> enum target_signal => enum gdb_signal
> 
> target_signal_from_host => gdb_signal_from_inferior
> target_signal_to_host => gdb_signal_to_inferior
> 
> gdbarch_target_signal_from_host => gdbarch_gdb_signal_from_inferior
> gdbarch_target_signal_to_host => gdbarch_gdb_signal_to_inferior


This blurs the point that gdb_signal_from_host/gdb_signal_from_inferior
should never be called if not from native/host code, IOW, only when you want
a mapping of the signal of the system the code is running on (host) and will
thus add to confusion.  I prefer my variant for making the distinction clear
with the naming.

-- 
Pedro Alves


  reply	other threads:[~2012-05-22 13:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20  2:03 Michael Eager
2012-05-21 11:04 ` Pedro Alves
2012-05-21 14:51   ` Michael Eager
2012-05-21 17:37     ` Pedro Alves
2012-05-21 18:06       ` Michael Eager
2012-05-21 18:19 ` Maciej W. Rozycki
     [not found] ` <alpine.DEB.1.10.1205211232260.11227@tp.orcam.me.uk>
2012-05-21 18:21   ` Michael Eager
2012-05-21 22:34     ` Maciej W. Rozycki
2012-05-22  9:38       ` Pedro Alves
2012-05-21 21:35 ` Pedro Alves
2012-05-21 21:53   ` Michael Eager
2012-05-21 22:48     ` Maciej W. Rozycki
2012-05-22  0:16       ` Michael Eager
2012-05-22 10:17       ` Pedro Alves
2012-05-22 13:16         ` Maciej W. Rozycki
2012-05-22 13:32           ` Pedro Alves [this message]
2012-05-22 15:10         ` Move store_waitstatus to inf-child.c (was: Re: MIPS Linux signals) Pedro Alves
2012-05-22 15:40         ` MIPS Linux signals Michael Eager
2012-05-22 16:02           ` Pedro Alves
2012-05-22 18:14             ` Michael Eager
2012-05-22 18:31               ` Pedro Alves
2012-05-22 19:32                 ` Michael Eager
2012-05-22 22:06                   ` Pedro Alves
2012-05-22 16:26         ` Pedro Alves
2012-05-22 10:58       ` Pedro Alves
2012-05-22 19:31         ` Aleksandar Ristovski
2012-05-22 21:55           ` Pedro Alves
2012-05-22 23:29             ` Aleksandar Ristovski
2012-05-23 11:39               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBB9546.5040505@redhat.com \
    --to=palves@redhat.com \
    --cc=eager@eagerm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox