From: Michael Eager <eager@eagerm.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: MIPS Linux signals
Date: Tue, 22 May 2012 00:16:00 -0000 [thread overview]
Message-ID: <4FBADAAF.5020409@eagerm.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1205212340180.11227@tp.orcam.me.uk>
On 05/21/2012 03:48 PM, Maciej W. Rozycki wrote:
> On Mon, 21 May 2012, Michael Eager wrote:
>
>>> BTW, I wouldn't bother with gdbarch_target_signal_to_host. Nothing ever
>>> calls it.
>>
>> I hadn't noticed that. I thought that it was called to translate
>> the signal number when sent to the target. Instead, target_signal_to_host()
>> is called.
>
> Shall we drop the unused gdbarch API so as to avoid further confusion
> then? Shouldn't target_signal_from_host be renamed to something closer to
> what it really does, e.g. signal_from_target? It's not that host signals
> really ever matter unless host == target in which case they're still
> target signals too (this observation applies to gdbserver as well).
This would be OK with me. The gdbarch_target_signal_to_host interface
suggests that this should differ for different targets.
There is an old bug report about the unclear name for the function.
gdbarch_signal_from_target would be a better name.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2012-05-22 0:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 2:03 Michael Eager
2012-05-21 11:04 ` Pedro Alves
2012-05-21 14:51 ` Michael Eager
2012-05-21 17:37 ` Pedro Alves
2012-05-21 18:06 ` Michael Eager
2012-05-21 18:19 ` Maciej W. Rozycki
[not found] ` <alpine.DEB.1.10.1205211232260.11227@tp.orcam.me.uk>
2012-05-21 18:21 ` Michael Eager
2012-05-21 22:34 ` Maciej W. Rozycki
2012-05-22 9:38 ` Pedro Alves
2012-05-21 21:35 ` Pedro Alves
2012-05-21 21:53 ` Michael Eager
2012-05-21 22:48 ` Maciej W. Rozycki
2012-05-22 0:16 ` Michael Eager [this message]
2012-05-22 10:17 ` Pedro Alves
2012-05-22 13:16 ` Maciej W. Rozycki
2012-05-22 13:32 ` Pedro Alves
2012-05-22 15:10 ` Move store_waitstatus to inf-child.c (was: Re: MIPS Linux signals) Pedro Alves
2012-05-22 15:40 ` MIPS Linux signals Michael Eager
2012-05-22 16:02 ` Pedro Alves
2012-05-22 18:14 ` Michael Eager
2012-05-22 18:31 ` Pedro Alves
2012-05-22 19:32 ` Michael Eager
2012-05-22 22:06 ` Pedro Alves
2012-05-22 16:26 ` Pedro Alves
2012-05-22 10:58 ` Pedro Alves
2012-05-22 19:31 ` Aleksandar Ristovski
2012-05-22 21:55 ` Pedro Alves
2012-05-22 23:29 ` Aleksandar Ristovski
2012-05-23 11:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBADAAF.5020409@eagerm.com \
--to=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox