Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/2: gdb)

[Pedro Alves <palves@redhat.com>]

On 04/24/2012 09:17 PM, Jeff Kenton wrote:

> On 04/24/2012 12:14 PM, Pedro Alves wrote:
>> Could you please split the series further one more time (and resubmit as a new thread, not as a reply to this one)? I'd like to see the host-independent tdep bits split out from the linux native debugger support (the nat bits). So you'll end up with 3 patches (you should be able to debug against gdbserver with just the tdep bits, and the gdbserver bits, for example.). That'll make it easier to see such issues and what else might need adjustment to current GDB's way of doing things. 
> 
> Hi Pedro,
> 
> Could you clarify this for me please.


> Are you asking me to re-distribute the existing files I submitted among 3 patches?

This.

Don't think in terms of files.  Think in terms of logical pieces.
There are 3 logical pieces to your patches.

 1 - gdb port base support for TILE-Gx.  The tdep files (unwinder, etc.), and associated
     glue.  These are host independent bits (can be compiled and used by a gdb running
     on any of the supported hosts.  E.g., a Windows gdb should be able to connect and debug
     tile target).  Generic TILE-Gx bits should be in tilegx-tdep.c, and GNU/Linux specific
     bits should be in a tilegx-linux-tdep.c file.
 2 - The GNU/Linux native port (the tilegx-linux-nat.c file and associated glue).  These files
     are only built when building a native gdb that will run on TILE-Gx machines.
 3 - The GNU/Linux gdbserver port.

Your patch currently mixes 1 and 2 together.  2 and 3 are similar in nature, although
the implementations are naturally a bit different given the different codebases.
E.g., with just patches 1 and 3, discarding 2, you should be able to debug a tile
target running gdbserver, connecting from a gdb running on a x86 host (with
gdb configured with --target=tile-unknown-linux-gnu) (if TILE-Gx is big endian, that'd
be a good test to flush out host-independence issues from patch 1).

-- 
Pedro Alves