From: Pedro Alves <palves@redhat.com>
To: Jeff Kenton <jkenton@tilera.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdbserver)
Date: Tue, 24 Apr 2012 17:34:00 -0000 [thread overview]
Message-ID: <4F96DBCE.9040205@redhat.com> (raw)
In-Reply-To: <4F95B4A8.4060204@tilera.com>
On 04/23/2012 08:59 PM, Jeff Kenton wrote:
>
> jeff kenton (jkenton@tilera.com)
Please see the numerous existing entries in gdb/ChangeLog (for example),
for the proper format of the CL entry's header.
>
> * New target
>
> Tilera TILE-Gx tilegx-*-*
You should turn this part into a proper NEWS patch. Also,
does the patch handle generic tilegx-elf, or just GNU/Linux
(tilegx-*-linux*)? Please adjust the triplet above to reflect reality.
> gdb/gdbserver/
> * configure.srv: added target: tilegx-*-linux*
> * linux-tile-low.c: new file
> * Makefile.in: added files linux-tile-low.c and reg-tilegx.o
Make that present tense, uppercase, and add full stops. Add the change's
context under ()'s. One change (reg-tilegx.c) was missing in the entry.
So you'd end up with:
* configure.srv: Add tilegx-*-linux*.
* linux-tile-low.c: New file.
* Makefile.in (SFILES): Add linux-tile-low.c.
(linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules.
--
Pedro Alves
next prev parent reply other threads:[~2012-04-24 16:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 19:26 [PATCH] Add support for Tilera TILE-Gx processor (part 1/2: gdb) Jeff Kenton
2012-04-20 1:58 ` Yao Qi
2012-04-20 12:54 ` Joel Brobecker
2012-04-20 14:03 ` Jeff Kenton
2012-04-21 0:34 ` Joel Brobecker
2012-04-23 19:59 ` Jeff Kenton
2012-04-24 16:07 ` Pedro Alves
2012-04-24 16:07 ` Pedro Alves
2012-04-24 16:07 ` Pedro Alves
2012-04-24 16:07 ` Pedro Alves
2012-04-24 16:08 ` Pedro Alves
2012-04-24 16:11 ` Pedro Alves
2012-04-24 16:14 ` Pedro Alves
2012-04-24 16:22 ` Pedro Alves
2012-04-24 18:47 ` Jeff Kenton
2012-04-24 20:21 ` Jeff Kenton
2012-04-24 22:40 ` Pedro Alves
2012-04-24 16:23 ` Pedro Alves
2012-04-24 16:27 ` Pedro Alves
2012-04-24 16:38 ` Pedro Alves
2012-04-24 16:40 ` Pedro Alves
2012-04-24 16:41 ` Pedro Alves
2012-04-24 16:41 ` Pedro Alves
2012-04-24 16:59 ` Jeff Kenton
2012-04-24 16:42 ` Pedro Alves
2012-04-24 16:54 ` Pedro Alves
2012-04-25 2:18 ` Yao Qi
2012-04-23 20:12 ` [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdbserver) Jeff Kenton
2012-04-24 16:54 ` Pedro Alves
2012-04-24 16:55 ` Pedro Alves
2012-04-24 17:34 ` Pedro Alves [this message]
2012-05-03 14:28 ` Jeff Kenton
2012-05-03 14:44 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F96DBCE.9040205@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jkenton@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox