From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10507 invoked by alias); 24 Apr 2012 16:59:23 -0000 Received: (qmail 10491 invoked by uid 22791); 24 Apr 2012 16:59:20 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 16:59:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OGwtGh015878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 Apr 2012 12:58:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3OGwsaM000587; Tue, 24 Apr 2012 12:58:54 -0400 Message-ID: <4F96DBCE.9040205@redhat.com> Date: Tue, 24 Apr 2012 17:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jeff Kenton CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdbserver) References: <4F906647.8090303@tilera.com> <20120420124306.GJ2852@adacore.com> <4F95B4A8.4060204@tilera.com> In-Reply-To: <4F95B4A8.4060204@tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00806.txt.bz2 On 04/23/2012 08:59 PM, Jeff Kenton wrote: > > jeff kenton (jkenton@tilera.com) Please see the numerous existing entries in gdb/ChangeLog (for example), for the proper format of the CL entry's header. > > * New target > > Tilera TILE-Gx tilegx-*-* You should turn this part into a proper NEWS patch. Also, does the patch handle generic tilegx-elf, or just GNU/Linux (tilegx-*-linux*)? Please adjust the triplet above to reflect reality. > gdb/gdbserver/ > * configure.srv: added target: tilegx-*-linux* > * linux-tile-low.c: new file > * Makefile.in: added files linux-tile-low.c and reg-tilegx.o Make that present tense, uppercase, and add full stops. Add the change's context under ()'s. One change (reg-tilegx.c) was missing in the entry. So you'd end up with: * configure.srv: Add tilegx-*-linux*. * linux-tile-low.c: New file. * Makefile.in (SFILES): Add linux-tile-low.c. (linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules. -- Pedro Alves