Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdbserver)

[Jeff Kenton <jkenton@tilera.com>]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

On 04/20/2012 08:43 AM, Joel Brobecker wrote:
> Hello Jeff,
>
> I agree on all of Yao's points. In addition, I would split your
> patches differently: I'd have one patch that adds support to GDB,
> and then another that adds support to GDBserver. I don't think
> it makes sense to have one patch with configury/Makefile changes
> on the one hand, because those changes do not make sense without
> the associated sources.
>
> If you need to be started on the copyright assignment, please
> let me know, and I will send you the form.
>


[-- Attachment #2: patch_2 --]
[-- Type: text/plain, Size: 6388 bytes --]


[PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdbserver)

I have re-organized my two part patch (submitted 4/19) in line
with suggestions from Joel and Yao.  It is now separated into a GDB
port and a GDBserver port (this part).

Comments please.

Thanks.

jeff kenton (jkenton@tilera.com)

    * New target

    Tilera TILE-Gx             tilegx-*-*

gdb/gdbserver/
    * configure.srv: added target: tilegx-*-linux*
    * linux-tile-low.c: new file
    * Makefile.in: added files linux-tile-low.c and reg-tilegx.o



diff -r -u -N /home/packages/gdb-7.4x/gdb/gdbserver/configure.srv ./gdb/gdbserver/configure.srv
--- /home/packages/gdb-7.4x/gdb/gdbserver/configure.srv	2012-03-13 11:00:37.000000000 -0400
+++ ./gdb/gdbserver/configure.srv	2012-04-23 13:01:20.430924000 -0400
@@ -311,6 +311,12 @@
 			srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
 			srv_linux_regsets=yes
 			;;
+  tilegx-*-linux*)	srv_regobj=reg-tilegx.o
+  			srv_tgtobj="linux-low.o linux-tile-low.o linux-osdata.o linux-procfs.o"
+			srv_tgtobj="${srv_tgtobj} linux-ptrace.o"
+  			srv_linux_regsets=yes
+  			srv_linux_thread_db=yes
+  			;;
   *)			echo "Error: target not supported by gdbserver."
 			exit 1
 			;;
diff -r -u -N /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c ./gdb/gdbserver/linux-tile-low.c
--- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c	1969-12-31 19:00:00.000000000 -0500
+++ ./gdb/gdbserver/linux-tile-low.c	2012-04-23 13:01:20.444911000 -0400
@@ -0,0 +1,146 @@
+
+
+/* GNU/Linux/TILE-Gx specific low level interface, GDBserver.
+
+   Copyright (C) 2012 Free Software Foundation, Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include "server.h"
+#include "linux-low.h"
+
+#include <sys/ptrace.h>
+
+/* Defined in auto-generated file reg-tile.c.  */
+void init_registers_tile (void);
+
+#define tile_num_regs 65
+
+static int tile_regmap[] =
+{
+   0,  1,  2,  3,  4,  5,  6,  7,
+   8,  9, 10, 11, 12, 13, 14, 15,
+  16, 17, 18, 19, 20, 21, 22, 23,
+  24, 25, 26, 27, 28, 29, 30, 31,
+  32, 33, 34, 35, 36, 37, 38, 39,
+  40, 41, 42, 43, 44, 45, 46, 47,
+  48, 49, 50, 51, 52, 53, 54, 55,
+  -1, -1, -1, -1, -1, -1, -1, -1,
+  56
+};
+
+static int
+tile_cannot_fetch_register (int regno)
+{
+  if (regno >= 0 && regno < 56)
+    return 0;
+  else if (regno == 64)
+    return 0;
+  else
+    return 1;
+}
+
+static int
+tile_cannot_store_register (int regno)
+{
+  if (regno >= 0 && regno < 56)
+    return 0;
+  else if (regno == 64)
+    return 0;
+  else
+    return 1;
+}
+
+static CORE_ADDR
+tile_get_pc (struct regcache *regcache)
+{
+  unsigned long pc;
+
+  collect_register_by_name (regcache, "pc", &pc);
+  return pc;
+}
+
+static void
+tile_set_pc (struct regcache *regcache, CORE_ADDR pc)
+{
+  unsigned long newpc = pc;
+
+  supply_register_by_name (regcache, "pc", &newpc);
+}
+
+static uint64_t tile_breakpoint = 0x400b3cae70166000ULL;
+#define tile_breakpoint_len 8
+
+static int
+tile_breakpoint_at (CORE_ADDR where)
+{
+  uint64_t insn;
+
+  (*the_target->read_memory) (where, (unsigned char *) &insn, 8);
+  if (insn == tile_breakpoint)
+    return 1;
+
+  /* If necessary, recognize more trap instructions here.  GDB only uses the
+     one.  */
+  return 0;
+}
+
+static void
+tile_fill_gregset (struct regcache *regcache, void *buf)
+{
+  int i;
+
+  for (i = 0; i < tile_num_regs; i++)
+    if (tile_regmap[i] != -1)
+      collect_register (regcache, i, ((unsigned int *) buf) + tile_regmap[i]);
+}
+
+static void
+tile_store_gregset (struct regcache *regcache, const void *buf)
+{
+  int i;
+  char zerobuf[8];
+
+  memset (zerobuf, 0, 8);
+  for (i = 0; i < tile_num_regs; i++)
+    if (tile_regmap[i] != -1)
+      supply_register (regcache, i, ((unsigned long *) buf) + tile_regmap[i]);
+    else
+      supply_register (regcache, i, zerobuf);
+}
+
+struct regset_info target_regsets[] = {
+  { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
+    GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
+  { 0, 0, 0, -1, -1, NULL, NULL }
+};
+
+struct linux_target_ops the_low_target = {
+  init_registers_tile,
+  tile_num_regs,
+  tile_regmap,
+  NULL,
+  tile_cannot_fetch_register,
+  tile_cannot_store_register,
+  NULL,
+  tile_get_pc,
+  tile_set_pc,
+  (const unsigned char *) &tile_breakpoint,
+  tile_breakpoint_len,
+  NULL,
+  0,
+  tile_breakpoint_at,
+};
diff -r -u -N /home/packages/gdb-7.4x/gdb/gdbserver/Makefile.in ./gdb/gdbserver/Makefile.in
--- /home/packages/gdb-7.4x/gdb/gdbserver/Makefile.in	2012-03-13 11:00:37.000000000 -0400
+++ ./gdb/gdbserver/Makefile.in	2012-04-23 13:01:20.410904000 -0400
@@ -120,6 +120,7 @@
 	$(srcdir)/linux-sh-low.c $(srcdir)/linux-sparc-low.c \
 	$(srcdir)/linux-x86-low.c \
 	$(srcdir)/linux-xtensa-low.c \
+	$(srcdir)/linux-tile-low.c \
 	$(srcdir)/win32-arm-low.c $(srcdir)/win32-i386-low.c \
 	$(srcdir)/win32-low.c $(srcdir)/wincecompat.c \
 	$(srcdir)/hostio.c $(srcdir)/hostio-errno.c \
@@ -479,6 +480,7 @@
 linux-x86-low.o: linux-x86-low.c $(linux_low_h) $(server_h) \
 	$(gdb_proc_service_h) $(i386_low_h) $(agent_h)
 linux-xtensa-low.o: linux-xtensa-low.c xtensa-xtregs.c $(linux_low_h) $(server_h)
+linux-tile-low.o: linux-tile-low.c $(linux_low_h) $(server_h)
 
 lynx-low.o: lynx-low.c $(server_h) $(target_h) $(lynx_low_h)
 lynx-ppc-low.o: lynx-ppc-low.c $(server_h) $(lynx_low_h)
@@ -670,4 +672,7 @@
 reg-xtensa.o : reg-xtensa.c $(regdef_h)
 reg-xtensa.c : $(srcdir)/../regformats/reg-xtensa.dat $(regdat_sh)
 	$(SHELL) $(regdat_sh) $(srcdir)/../regformats/reg-xtensa.dat reg-xtensa.c
+reg-tilegx.o : reg-tilegx.c $(regdef_h)
+reg-tilegx.c : $(srcdir)/../regformats/reg-tilegx.dat $(regdat_sh)
+	$(SHELL) $(regdat_sh) $(srcdir)/../regformats/reg-tilegx.dat reg-tilegx.c
 # This is the end of "Makefile.in".