From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11111 invoked by alias); 24 Apr 2012 21:41:54 -0000 Received: (qmail 11102 invoked by uid 22791); 24 Apr 2012 21:41:53 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 21:41:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OLfCBH023118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 Apr 2012 17:41:12 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3OLfAXK011701; Tue, 24 Apr 2012 17:41:11 -0400 Message-ID: <4F971DF6.6020402@redhat.com> Date: Tue, 24 Apr 2012 22:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jeff Kenton CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/2: gdb) References: <4F906647.8090303@tilera.com> <20120420124306.GJ2852@adacore.com> <4F95B46D.1070101@tilera.com> <4F96D15B.9090506@redhat.com> <4F970A44.8060109@tilera.com> In-Reply-To: <4F970A44.8060109@tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00834.txt.bz2 On 04/24/2012 09:17 PM, Jeff Kenton wrote: > On 04/24/2012 12:14 PM, Pedro Alves wrote: >> Could you please split the series further one more time (and resubmit as a new thread, not as a reply to this one)? I'd like to see the host-independent tdep bits split out from the linux native debugger support (the nat bits). So you'll end up with 3 patches (you should be able to debug against gdbserver with just the tdep bits, and the gdbserver bits, for example.). That'll make it easier to see such issues and what else might need adjustment to current GDB's way of doing things. > > Hi Pedro, > > Could you clarify this for me please. > Are you asking me to re-distribute the existing files I submitted among 3 patches? This. Don't think in terms of files. Think in terms of logical pieces. There are 3 logical pieces to your patches. 1 - gdb port base support for TILE-Gx. The tdep files (unwinder, etc.), and associated glue. These are host independent bits (can be compiled and used by a gdb running on any of the supported hosts. E.g., a Windows gdb should be able to connect and debug tile target). Generic TILE-Gx bits should be in tilegx-tdep.c, and GNU/Linux specific bits should be in a tilegx-linux-tdep.c file. 2 - The GNU/Linux native port (the tilegx-linux-nat.c file and associated glue). These files are only built when building a native gdb that will run on TILE-Gx machines. 3 - The GNU/Linux gdbserver port. Your patch currently mixes 1 and 2 together. 2 and 3 are similar in nature, although the implementations are naturally a bit different given the different codebases. E.g., with just patches 1 and 3, discarding 2, you should be able to debug a tile target running gdbserver, connecting from a gdb running on a x86 host (with gdb configured with --target=tile-unknown-linux-gnu) (if TILE-Gx is big endian, that'd be a good test to flush out host-independence issues from patch 1). -- Pedro Alves