From: Yao Qi <yao@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011
Date: Wed, 27 Apr 2011 03:16:00 -0000 [thread overview]
Message-ID: <4DB78A74.9060105@codesourcery.com> (raw)
In-Reply-To: <20110427015455.GA24839@sourceware.org>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On 04/27/2011 09:54 AM, GDB Administrator wrote:
> 119a120
>> gdb/common/linux-ptrace.h:22: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> gdb/common/linux-ptrace.h:22:#include <sys/wait.h>
sys/wait.h is included for macro __WALL. However, we can safely remove
this include from common/linux-ptrace.h because either sys/wait.h or
gdb_wait.h is included before including linux-ptrace.h in linux-nat.c
and linux-low.c.
In linux-nat.c, gdb_wait.h is included in line 25, and linux-ptrace.h is
included in line 33. In linux-low.c, sys/wait.h is included in line 23,
and linux-ptrace.h is included in line 27.
Is it OK?
--
Yao (é½å°§)
[-- Attachment #2: remove_include_sys_wait.patch --]
[-- Type: text/x-patch, Size: 587 bytes --]
2011-04-27 Yao Qi <yao@codesourcery.com>
* common/linux-ptrace.h: Remove include <sys/wait.h>.
Index: common/linux-ptrace.h
===================================================================
RCS file: /cvs/src/src/gdb/common/linux-ptrace.h,v
retrieving revision 1.1
diff -u -r1.1 linux-ptrace.h
--- common/linux-ptrace.h 26 Apr 2011 15:36:04 -0000 1.1
+++ common/linux-ptrace.h 27 Apr 2011 02:52:53 -0000
@@ -19,7 +19,6 @@
#define COMMON_LINUX_PTRACE_H
#include <sys/ptrace.h>
-#include <sys/wait.h> /* __WAIT */
#ifndef PTRACE_GETSIGINFO
# define PTRACE_GETSIGINFO 0x4202
next prev parent reply other threads:[~2011-04-27 3:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 1:55 GDB Administrator
2011-04-27 3:16 ` Yao Qi [this message]
2011-04-27 14:53 ` Tom Tromey
2011-04-27 15:08 ` Joel Brobecker
2011-04-27 15:48 ` Yao Qi
2011-04-27 16:18 ` Joel Brobecker
2011-04-27 16:44 ` Mark Kettenis
2011-04-27 16:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB78A74.9060105@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox